Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 290cc58

Browse files
askeksacommit-bot@chromium.org
authored andcommitted
Use actual receiver when error-wrapping a null-aware property get.
Fixes the crash on conditional_property_access_test_{05,06}.dart from dart-lang/sdk#32800 Change-Id: Ic3928b345c235472d6632e8bc443f28d59b81f6b Reviewed-on: https://dart-review.googlesource.com/49920 Reviewed-by: Dmitry Stefantsov <[email protected]> Commit-Queue: Aske Simon Christensen <[email protected]>
1 parent 34763bc commit 290cc58

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1389,7 +1389,7 @@ abstract class TypeInferrerImpl extends TypeInferrer {
13891389
receiverType, propertyName, fileOffset,
13901390
errorTemplate: templateUndefinedGetter,
13911391
expression: expression,
1392-
receiver: desugaredGet.receiver);
1392+
receiver: receiver);
13931393
if (interfaceMember is Member) {
13941394
desugaredGet.interfaceTarget = interfaceMember;
13951395
}

tests/co19/co19-kernel.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,7 @@ Language/Expressions/Property_Extraction/Super_Getter_Access_and_Method_Closuriz
708708
Language/Expressions/Property_Extraction/Super_Getter_Access_and_Method_Closurization/no_such_method_t02: CompileTimeError
709709
Language/Expressions/Property_Extraction/Super_Getter_Access_and_Method_Closurization/static_type_t03: CompileTimeError
710710
Language/Expressions/Property_Extraction/Super_Getter_Access_and_Method_Closurization/static_type_warning_t01: CompileTimeError
711-
Language/Expressions/Property_Extraction/conditional_t06: Crash
711+
Language/Expressions/Property_Extraction/conditional_t06: CompileTimeError
712712
Language/Expressions/Property_Extraction/static_type_warning_t01/01: CompileTimeError
713713
Language/Expressions/Relational_Expressions/syntax_t01/01: CompileTimeError
714714
Language/Expressions/Relational_Expressions/syntax_t01/02: CompileTimeError

tests/language_2/language_2_kernel.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,8 +1202,6 @@ compile_time_constant_static5_test/21: CompileTimeError
12021202
compile_time_constant_static5_test/23: CompileTimeError
12031203
conditional_import_string_test: CompileTimeError
12041204
conditional_import_test: CompileTimeError
1205-
conditional_property_access_test/05: Crash
1206-
conditional_property_access_test/06: Crash
12071205
config_import_corelib_test: CompileTimeError
12081206
config_import_test: Crash
12091207
const_constructor3_test/04: MissingCompileTimeError

0 commit comments

Comments
 (0)