Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 326a1c4

Browse files
author
peihan.cph
committed
fix ci build error
1 parent 9fd15dc commit 326a1c4

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

shell/common/shell.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,12 +291,12 @@ static void PerformInitializationTasks(const Settings& settings) {
291291
}
292292

293293
std::unique_ptr<Shell> Shell::Create(
294-
fml::closure& async_init_callback,
295294
TaskRunners task_runners,
296295
Settings settings,
297296
const Shell::CreateCallback<PlatformView>& on_create_platform_view,
298297
const Shell::CreateCallback<Rasterizer>& on_create_rasterizer) {
299-
return Shell::Create(async_init_callback, //
298+
fml::closure empty_func;
299+
return Shell::Create(empty_func, //init sync as before
300300
std::move(task_runners), //
301301
WindowData{/* default window data */}, //
302302
std::move(settings), //

shell/common/shell.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,6 @@ class Shell final : public PlatformView::Delegate,
101101
/// If this is the first instance of a shell in the process, this
102102
/// call also bootstraps the Dart VM.
103103
///
104-
/// @param[in] async_init_callback if null,init sync.
105-
/// else init async.and called when
106-
/// asyncInit end
107104
/// @param[in] task_runners The task runners
108105
/// @param[in] settings The settings
109106
/// @param[in] on_create_platform_view The callback that must return a
@@ -124,7 +121,6 @@ class Shell final : public PlatformView::Delegate,
124121
/// immediately after getting a pointer to it.
125122
///
126123
static std::unique_ptr<Shell> Create(
127-
fml::closure& async_init_callback,
128124
TaskRunners task_runners,
129125
Settings settings,
130126
const CreateCallback<PlatformView>& on_create_platform_view,

shell/platform/fuchsia/flutter/engine.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,9 @@ Engine::Engine(Delegate& delegate,
238238

239239
{
240240
TRACE_EVENT0("flutter", "CreateShell");
241+
fml::closure empty_func;
241242
shell_ = flutter::Shell::Create(
243+
empty_func,
242244
task_runners, // host task runners
243245
flutter::WindowData(), // default window data
244246
settings_, // shell launch settings

0 commit comments

Comments
 (0)