Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 34be5de

Browse files
committed
Fixed _DomRect class to map to both ClientRect and DOMRect for browser backward compat.
[email protected],[email protected] Change-Id: I2f5ccae15bcd993ab1e15ab556a25d6e0cd1d450 Reviewed-on: https://dart-review.googlesource.com/50504 Reviewed-by: Stephen Adams <[email protected]> Commit-Queue: Terry Lucas <[email protected]>
1 parent 5c508ff commit 34be5de

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

sdk/lib/html/dart2js/html_dart2js.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44997,7 +44997,7 @@ abstract class _DocumentType extends Node implements ChildNode {
4499744997
@DocsEditable()
4499844998
@DomName('DOMRect')
4499944999
@Experimental() // untriaged
45000-
@Native("DOMRect")
45000+
@Native("ClientRect,DOMRect")
4500145001
class _DomRect extends DomRectReadOnly implements Rectangle {
4500245002
// NOTE! All code below should be common with RectangleBase.
4500345003
String toString() {

tools/dom/scripts/generator.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,8 @@ def ReturnValueConversionHack(idl_type, value, interface_name):
275275
'ChannelMergerNode': 'ChannelMergerNode,AudioChannelMerger',
276276
'ChannelSplitterNode': 'ChannelSplitterNode,AudioChannelSplitter',
277277

278+
'DOMRect': 'ClientRect,DOMRect',
279+
278280
'DOMRectList': 'ClientRectList,DOMRectList',
279281

280282
'CSSStyleDeclaration':

0 commit comments

Comments
 (0)