Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 3a1e9bb

Browse files
committed
bump fuchsia toolchain to clang-12
1 parent 6edb402 commit 3a1e9bb

File tree

6 files changed

+38
-36
lines changed

6 files changed

+38
-36
lines changed

DEPS

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ allowed_hosts = [
100100
]
101101

102102
deps = {
103-
'src': 'https://github.com/flutter/buildroot.git' + '@' + '64bf32094b19bfecc2515aedb7e130f7ba15d297',
103+
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'c80bb183b30b3df12a3d8a6db235c0171c10d6a0',
104104

105105
# Fuchsia compatibility
106106
#
@@ -534,16 +534,6 @@ deps = {
534534
'condition': 'host_os == "mac"',
535535
'dep_type': 'cipd',
536536
},
537-
'src/fuchsia/toolchain/mac': {
538-
'packages': [
539-
{
540-
'package': 'fuchsia/clang/mac-amd64',
541-
'version': 'OzTZOKkICT0yD82Dbx0jvVn5hN5eOSi6ByVTDseE7i0C'
542-
}
543-
],
544-
'condition': 'host_os == "mac"',
545-
'dep_type': 'cipd',
546-
},
547537
'src/fuchsia/sdk/linux': {
548538
'packages': [
549539
{
@@ -554,16 +544,16 @@ deps = {
554544
'condition': 'host_os == "linux"',
555545
'dep_type': 'cipd',
556546
},
557-
'src/fuchsia/toolchain/linux': {
547+
'src/fuchsia/toolchain/{host_os}': {
558548
'packages': [
559549
{
560-
'package': 'fuchsia/clang/linux-amd64',
561-
'version': 'OT6p30bQQhyCzRSy7xPsSbZ88J3PWOnneenkMZ0j7kIC'
550+
'package': 'fuchsia/third_party/clang/${{platform}}',
551+
'version': 'git_revision:2c0536b76b35fa592ac7b4a0e4bb176eaf55af75'
562552
}
563-
],
564-
'condition': 'host_os == "linux"',
565-
'dep_type': 'cipd',
566-
},
553+
],
554+
'condition': 'host_os == "mac" or host_os == "linux"',
555+
'dep_type': 'cipd',
556+
},
567557
}
568558

569559
hooks = [

ci/licenses_golden/licenses_skia

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Signature: 5cf4054651324cb2c6b3906a419b7e08
1+
Signature: b4334e5d7da65d0622440f3b60e1a725
22

33
UNUSED LICENSES:
44

@@ -3941,6 +3941,8 @@ FILE: ../../../third_party/skia/src/gpu/GrStagingBufferManager.cpp
39413941
FILE: ../../../third_party/skia/src/gpu/GrStagingBufferManager.h
39423942
FILE: ../../../third_party/skia/src/gpu/GrStencilMaskHelper.cpp
39433943
FILE: ../../../third_party/skia/src/gpu/GrStencilMaskHelper.h
3944+
FILE: ../../../third_party/skia/src/gpu/GrSurfaceFillContext.cpp
3945+
FILE: ../../../third_party/skia/src/gpu/GrSurfaceFillContext.h
39443946
FILE: ../../../third_party/skia/src/gpu/GrUniformDataManager.cpp
39453947
FILE: ../../../third_party/skia/src/gpu/GrUniformDataManager.h
39463948
FILE: ../../../third_party/skia/src/gpu/GrUtil.cpp

ci/licenses_golden/licenses_third_party

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Signature: a8cc0000d2c343f5ff41a0cd561da725
1+
Signature: 26db1839487f484ffd88b8d3c74bf3e0
22

33
UNUSED LICENSES:
44

tools/fuchsia/clang.gni

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ if (is_fuchsia) {
2626
assert(false, "OS not supported")
2727
}
2828

29-
clang_manifest = rebase_path("$clang_base/${clang_target}.manifest")
29+
clang_manifest = rebase_path("$clang_base/runtime.json")
3030
clang_manifest_json = exec_script("//flutter/tools/fuchsia/parse_manifest.py",
31-
[ "--input=${clang_manifest}" ],
31+
[
32+
"--input=${clang_manifest}",
33+
"--clang-cpu=${clang_cpu}",
34+
],
3235
"json")

tools/fuchsia/fuchsia_libs.gni

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,17 @@ common_libs = [
4848
{
4949
name = "libc++.so.2"
5050
path = rebase_path(
51-
"$clang_base/${clang_manifest_json.md5_33bfe15b05ada4ed326fbc33adb39b95}")
51+
"$clang_base/${clang_manifest_json.md5_19df03aecdc9eb27bc8b4038352f2b27}")
5252
},
5353
{
5454
name = "libc++abi.so.1"
5555
path = rebase_path(
56-
"$clang_base/${clang_manifest_json.md5_916c01a85e3353f124776599819ecb1c}")
56+
"$clang_base/${clang_manifest_json.md5_6aff1b5f218d4a9278d85d63d0695af8}")
5757
},
5858
{
5959
name = "libunwind.so.1"
6060
path = rebase_path(
61-
"$clang_base/${clang_manifest_json.md5_beb70f40d525448b39ea87d9f5811e56}")
61+
"$clang_base/${clang_manifest_json.md5_fb2bd871885ef42c2cf3138655f901ed}")
6262
},
6363
]
6464

tools/fuchsia/parse_manifest.py

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,34 @@
1212
import sys
1313
import hashlib
1414

15-
1615
def main():
1716
parser = argparse.ArgumentParser()
1817

1918
parser.add_argument(
2019
'--input', dest='file_path', action='store', required=True)
20+
parser.add_argument(
21+
'--clang-cpu', dest='clang_cpu', action='store', required=True)
2122

2223
args = parser.parse_args()
2324

24-
files = open(args.file_path, 'r')
25-
lines = files.read().split()
25+
with open(args.file_path) as f:
26+
data = json.load(f)
2627

2728
output = {}
28-
29-
for line in lines:
30-
key, val = line.strip().split('=')
31-
md5 = hashlib.md5(key.encode()).hexdigest()
32-
hash_key = 'md5_%s' % md5
33-
# Uncomment this line to get the hash keys
34-
# print val, hash_key
35-
output[hash_key] = os.path.dirname(val)
29+
target = args.clang_cpu + '-fuchsia'
30+
31+
for d in data:
32+
if target in d['target']:
33+
for runtime in d['runtime']:
34+
# key contains the soname and the cflags used to compile it.
35+
# this allows us to distinguish between different sanitizers
36+
# and experiments
37+
key = runtime['soname'] + ''.join(d['cflags'])
38+
md5 = hashlib.md5(key.encode()).hexdigest()
39+
hash_key = 'md5_%s' % md5
40+
# Uncomment this line to get the hash keys
41+
# print runtime['dist'], d['cflags'], hash_key
42+
output[hash_key] = os.path.dirname(runtime['dist'])
3643

3744
print(json.dumps(output))
3845

0 commit comments

Comments
 (0)