Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 44c7507

Browse files
mspangCommit Bot
authored and
Commit Bot
committed
Fuchsia: Disable GLES3 testing on Fuchsia ARM
The vulkan driver is missing required extensions so these tests are all failing. Bug: angleproject:4352 Change-Id: Id1af7c40798d8844fbf832c6066260fe3a8bfeda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023911 Commit-Queue: Michael Spang <[email protected]> Reviewed-by: Jamie Madill <[email protected]>
1 parent e28883d commit 44c7507

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/tests/test_utils/angle_test_instantiate.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,11 @@ bool IsAMD()
246246
return HasSystemVendorID(kVendorID_AMD);
247247
}
248248

249+
bool IsARM()
250+
{
251+
return HasSystemVendorID(kVendorID_ARM);
252+
}
253+
249254
bool IsNVIDIA()
250255
{
251256
#if defined(ANGLE_PLATFORM_ANDROID)
@@ -363,6 +368,11 @@ bool IsConfigWhitelisted(const SystemInfo &systemInfo, const PlatformParameters
363368
return false;
364369
}
365370

371+
// ES 3 configs do not work properly on Fuchsia ARM.
372+
// TODO(anglebug.com/4352): Investigate missing features.
373+
if (param.majorVersion > 2 && IsARM())
374+
return false;
375+
366376
// Currently we only support the Vulkan back-end on Fuchsia.
367377
return (param.getRenderer() == EGL_PLATFORM_ANGLE_TYPE_VULKAN_ANGLE);
368378
}

src/tests/test_utils/angle_test_instantiate.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,11 @@ bool IsPixel2();
3737
bool IsPixel2XL();
3838
bool IsNVIDIAShield();
3939

40-
// Desktop devices.
40+
// GPU vendors.
4141
bool IsIntel();
4242
bool IsAMD();
4343
bool IsNVIDIA();
44+
bool IsARM();
4445

4546
inline bool IsASan()
4647
{

0 commit comments

Comments
 (0)