Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 4dd5e6e

Browse files
rakudramacommit-bot@chromium.org
authored andcommitted
js_runtime: fix _JsonMap keys list type
[email protected] Change-Id: Iec7d7e5229cb96e739e3d3bde73f5ce3534c5827 Reviewed-on: https://dart-review.googlesource.com/50020 Commit-Queue: Stephen Adams <[email protected]> Reviewed-by: Stephen Adams <[email protected]> Reviewed-by: Sigmund Cherem <[email protected]>
1 parent 71ffe97 commit 4dd5e6e

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

sdk/lib/_internal/js_runtime/lib/convert_patch.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import 'dart:_js_helper' show argumentErrorValue, patch;
88
import 'dart:_foreign_helper' show JS;
9-
import 'dart:_interceptors' show JSExtendableArray;
9+
import 'dart:_interceptors' show JSArray, JSExtendableArray;
1010
import 'dart:_internal' show MappedIterable, ListIterable;
1111
import 'dart:collection' show LinkedHashMap, MapBase;
1212
import 'dart:_native_typed_data' show NativeUint8List;
@@ -274,7 +274,7 @@ class _JsonMap extends MapBase<String, dynamic> {
274274
assert(!_isUpgraded);
275275
List keys = _data;
276276
if (keys == null) {
277-
keys = _data = _getPropertyNames(_original);
277+
keys = _data = new JSArray<String>.typed(_getPropertyNames(_original));
278278
}
279279
return JS('JSExtendableArray', '#', keys);
280280
}

tests/corelib_2/corelib_2.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ iterable_followed_by_test: RuntimeError
227227
iterable_return_type_test/01: RuntimeError # Issue 20085
228228
iterable_return_type_test/02: RuntimeError # Dart2js does not support Uint64*.
229229
iterable_to_list_test/01: RuntimeError # Issue 26501
230-
json_map_test: RuntimeError
231230
list_concurrent_modify_test: RuntimeError # dart2js does not fully implement these
232231
list_test/01: RuntimeError
233232
list_test/none: RuntimeError
@@ -259,7 +258,6 @@ iterable_followed_by_test: RuntimeError
259258
iterable_return_type_test/01: RuntimeError # Issue 20085
260259
iterable_return_type_test/02: RuntimeError # Dart2js does not support Uint64*.
261260
iterable_to_list_test/01: RuntimeError # Issue 26501
262-
json_map_test: RuntimeError
263261
list_concurrent_modify_test: RuntimeError # dart2js does not fully implement these
264262
list_test/01: RuntimeError
265263
list_test/none: RuntimeError

0 commit comments

Comments
 (0)