dartdocs

Author: mdebbar

lib/web_ui/lib/src/engine/history/js_url_strategy.dart

@@ -33,7 +33,6 @@ JsUrlStrategy? convertToJsUrlStrategy(UrlStrategy? strategy) {
     pushState: allowInterop(strategy.pushState),
     replaceState: allowInterop(strategy.replaceState),
     go: allowInterop(strategy.go),
-    // getBaseHref: allowInterop(strategy.getBaseHref),
   );
 }
 
@@ -78,7 +77,4 @@ abstract class JsUrlStrategy {
 
   /// Moves forwards or backwards through the history stack.
   external Future<void> go(int count);
-
-  // TODO: add this:
-  // external String getBaseHref();
 }

lib/web_ui/lib/src/engine/history/url_strategy.dart

@@ -134,7 +134,7 @@ class HashUrlStrategy extends UrlStrategy {
 /// [UrlStrategy] when they need to interact with the DOM apis like
 /// pushState, popState, etc...
 abstract class PlatformLocation {
-  ///
+  /// This constructor is here only to allow subclasses to be const.
   const PlatformLocation();
 
   /// Registers an event listener for the `onpopstate` event.
@@ -183,11 +183,14 @@ abstract class PlatformLocation {
   ///
   /// See: https://developer.mozilla.org/en-US/docs/Web/API/History/go
   void go(int count);
+
+  /// The base href where the flutter app is being served.
+  String? getBaseHref();
 }
 
 /// An implementation of [PlatformLocation] for the browser.
 class BrowserPlatformLocation extends PlatformLocation {
-  ///
+  /// Default constructor for [BrowserPlatformLocation].
   const BrowserPlatformLocation();
 
   html.Location get _location => html.window.location;
@@ -229,4 +232,7 @@ class BrowserPlatformLocation extends PlatformLocation {
   void go(int count) {
     _history.go(count);
   }
+
+  @override
+  String? getBaseHref() => html.document.baseUri;
 }

lib/web_ui/lib/src/engine/window.dart

@@ -801,10 +801,7 @@ class EngineWindow extends ui.Window {
   }
 
   void _addUrlStrategyListener() {
-    // TODO(mdebbar): Do we need "allowInterop" here?
-    _onUrlStrategy = allowInterop((JsUrlStrategy strategy) {
-      setUrlStrategy(strategy);
-    });
+    _onUrlStrategy = setUrlStrategy;
     registerHotRestartListener(() {
       _onUrlStrategy = null;
     });