draft 0

Author: Chris Yang

shell/common/animator.cc

@@ -76,6 +76,12 @@ void Animator::EnqueueTraceFlowId(uint64_t trace_flow_id) {
       });
 }
 
+void Animator::RecordFrameDuration(const int64_t frame_duration) {
+  TRACE_EVENT0("flutter", "Engine::RecordFrameDuration");
+  FML_DCHECK(frame_duration >= 0);
+  FML_DLOG(ERROR) << "frame duration " << frame_duration;
+}
+
 // This Parity is used by the timeline component to correctly align
 // GPU Workloads events with their respective Framework Workload.
 const char* Animator::FrameParity() {

shell/common/animator.h

@@ -83,6 +83,15 @@ class Animator final {
   // active rendering.
   void EnqueueTraceFlowId(uint64_t trace_flow_id);
 
+  //----------------------------------------------------------------------------
+  /// @brief      Record the frame duration of the last frame.
+  ///
+  /// @param[in]  frame_duration  The delta between raster end time and build
+  ///                             start time, in milliseconds. This value must
+  ///                             be positive
+  ///
+  void RecordFrameDuration(const int64_t frame_duration);
+
  private:
   using LayerTreePipeline = Pipeline<flutter::LayerTree>;
 

shell/common/engine.cc

@@ -246,6 +246,12 @@ void Engine::ReportTimings(std::vector<int64_t> timings) {
   runtime_controller_->ReportTimings(std::move(timings));
 }
 
+void Engine::RecordFrameDuration(const int64_t frame_duration) {
+  TRACE_EVENT0("flutter", "Engine::RecordFrameDuration");
+  FML_DCHECK(frame_duration >= 0);
+  animator_->RecordFrameDuration(frame_duration);
+}
+
 void Engine::NotifyIdle(int64_t deadline) {
   auto trace_event = std::to_string(deadline - Dart_TimelineGetMicros());
   TRACE_EVENT1("flutter", "Engine::NotifyIdle", "deadline_now_delta",

shell/common/engine.h

@@ -583,6 +583,15 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
   ///
   void ReportTimings(std::vector<int64_t> timings);
 
+  //----------------------------------------------------------------------------
+  /// @brief      Record the frame duration of the last frame.
+  ///
+  /// @param[in]  frame_duration  The delta between raster end time and build
+  ///                             start time, in milliseconds. This value must
+  ///                             be positive
+  ///
+  void RecordFrameDuration(const int64_t frame_duration);
+
   //----------------------------------------------------------------------------
   /// @brief      Gets the main port of the root isolate. Since the isolate is
   ///             created immediately in the constructor of the engine, it is

shell/common/shell.cc

@@ -1361,6 +1361,12 @@ void Shell::OnFrameRasterized(const FrameTiming& timing) {
     settings_.frame_rasterized_callback(timing);
   }
 
+  int64_t frame_duration_ms = (timing.Get(FrameTiming::Phase::kBuildStart) -
+                               timing.Get(FrameTiming::Phase::kRasterFinish))
+                                  .ToMilliseconds();
+
+  engine_->RecordFrameDuration(frame_duration_ms);
+
   if (!needs_report_timings_) {
     return;
   }