Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 7527889

Browse files
authored
[Impeller] Don't enable KHR_debug on Angle. (#56601)
All it does it log the calls and overwhelms the output for no utility. <img width="651" alt="Screenshot 2024-11-14 at 3 53 54�PM" src="https://github.com/user-attachments/assets/b2de0d71-6263-4f00-94a0-73a5c0d0135d">
1 parent df915a2 commit 7527889

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

impeller/renderer/backend/gles/description_gles.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,10 @@ bool DescriptionGLES::HasExtension(const std::string& ext) const {
178178
}
179179

180180
bool DescriptionGLES::HasDebugExtension() const {
181-
return HasExtension("GL_KHR_debug");
181+
// Angle just logs calls instead of forwarding debug information to the
182+
// backend. This just overwhelms the logs and is of limited use. Disable on
183+
// Angle.
184+
return HasExtension("GL_KHR_debug") && !IsANGLE();
182185
}
183186

184187
} // namespace impeller

0 commit comments

Comments
 (0)