Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 8c27891

Browse files
authored
Fix build/dart/rules.gni which contains erroneous code after my refactor. (#54867)
In #54845, I removed `common_vm_args = ['--disable-dart-dev']`, but the resulting change created invalid code `vm_args = (args = common_args)`. We don't seem to run this configuration on our own CI, so it wasn't noticed, but it broke the Dart monorepo build, which does use it: https://ci.chromium.org/p/dart/g/monorepo/console https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8738311211510911329/+/u/gn_--runtime-mode_debug_--full-dart-sdk_--rbe_--no-goma_--unoptimized_--no-prebuilt-dart-sdk_--gn-args_engine_version__5295ec1b816af727165015d84d4a1091520122ae__--rbe-server-address_unix:___b_s_w_ir_x_w_recipe_cleanup_rbe4v23ir8o_reproxy.sock/stdout I am open to reverting instead, but this seems straight-forward enough for something that isn't tested on either pre or post-submit.
1 parent 339955b commit 8c27891

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build/dart/rules.gni

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ template("flutter_frontend_server") {
120120
inputs = [ invoker.main_dart ]
121121
outputs = [ invoker.kernel_output ]
122122
depfile = snapshot_depfile
123-
vm_args = (args = common_args)
123+
args = common_args
124124
}
125125
}
126126
}

0 commit comments

Comments
 (0)