Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 8c28431

Browse files
[Impeller] Vulkan validation off by default. (#52397) (#52904)
Fixes flutter/flutter#142659 can be turned on via --enable-vulkan-validation cmd line flag. Cherry pick request to unbreak android emulators.
1 parent f6344b7 commit 8c28431

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

shell/platform/android/io/flutter/embedding/engine/loader/FlutterLoader.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,12 @@
44

55
package io.flutter.embedding.engine.loader;
66

7-
import static io.flutter.Build.API_LEVELS;
8-
97
import android.app.ActivityManager;
108
import android.content.Context;
119
import android.content.pm.ApplicationInfo;
1210
import android.content.pm.PackageManager;
1311
import android.content.res.AssetManager;
1412
import android.hardware.display.DisplayManager;
15-
import android.os.Build;
1613
import android.os.Bundle;
1714
import android.os.Handler;
1815
import android.os.Looper;
@@ -237,13 +234,6 @@ public InitResult call() {
237234
}
238235
}
239236

240-
private static boolean areValidationLayersOnByDefault() {
241-
if (BuildConfig.DEBUG && Build.VERSION.SDK_INT >= API_LEVELS.API_26) {
242-
return Build.SUPPORTED_ABIS[0].equals("arm64-v8a");
243-
}
244-
return false;
245-
}
246-
247237
/**
248238
* Blocks until initialization of the native system has completed.
249239
*
@@ -353,8 +343,7 @@ public void ensureInitializationComplete(
353343
if (metaData.getBoolean(ENABLE_IMPELLER_META_DATA_KEY, false)) {
354344
shellArgs.add("--enable-impeller");
355345
}
356-
if (metaData.getBoolean(
357-
ENABLE_VULKAN_VALIDATION_META_DATA_KEY, areValidationLayersOnByDefault())) {
346+
if (metaData.getBoolean(ENABLE_VULKAN_VALIDATION_META_DATA_KEY, false)) {
358347
shellArgs.add("--enable-vulkan-validation");
359348
}
360349
if (metaData.getBoolean(IMPELLER_OPENGL_GPU_TRACING_DATA_KEY, false)) {

0 commit comments

Comments
 (0)