Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 8d03bef

Browse files
jason-simmonsharryterkelsen
authored andcommitted
Declare native wrapper classes in Fuchsia packages as base classes (#46305)
This prohibits other implementations of the class interface that can not act as native wrappers. See flutter/flutter#123756
1 parent 85e36eb commit 8d03bef

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

shell/platform/fuchsia/dart-pkg/zircon/lib/src/handle.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ part of zircon;
88
// ignore_for_file: public_member_api_docs
99

1010
@pragma('vm:entry-point')
11-
class Handle extends NativeFieldWrapperClass1 {
11+
base class Handle extends NativeFieldWrapperClass1 {
1212
// No public constructor - this can only be created from native code.
1313
@pragma('vm:entry-point')
1414
Handle._();

shell/platform/fuchsia/dart-pkg/zircon/lib/src/handle_disposition.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ part of zircon;
88
// ignore_for_file: public_member_api_docs
99

1010
@pragma('vm:entry-point')
11-
class HandleDisposition extends NativeFieldWrapperClass1 {
11+
base class HandleDisposition extends NativeFieldWrapperClass1 {
1212
@pragma('vm:entry-point')
1313
HandleDisposition(int operation, Handle handle, int type, int rights) {
1414
_constructor(operation, handle, type, rights);

shell/platform/fuchsia/dart-pkg/zircon/lib/src/handle_waiter.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ part of zircon;
1010
typedef AsyncWaitCallback = void Function(int status, int pending);
1111

1212
@pragma('vm:entry-point')
13-
class HandleWaiter extends NativeFieldWrapperClass1 {
13+
base class HandleWaiter extends NativeFieldWrapperClass1 {
1414
// Private constructor.
1515
@pragma('vm:entry-point')
1616
HandleWaiter._();

shell/platform/fuchsia/dart-pkg/zircon/lib/src/system.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ class MapResult extends _Result {
193193
}
194194

195195
@pragma('vm:entry-point')
196-
class System extends NativeFieldWrapperClass1 {
196+
base class System extends NativeFieldWrapperClass1 {
197197
// No public constructor - this only has static methods.
198198
System._();
199199

0 commit comments

Comments
 (0)