Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 938b453

Browse files
reed-at-googleSkia Commit-Bot
authored and
Skia Commit-Bot
committed
Revert "transition matrix44 to opt-in only"
This reverts commit 0f1f87d. Reason for revert: google3 and flutter also need the guard Original change's description: > transition matrix44 to opt-in only > > In service of https://chromium-review.googlesource.com/c/chromium/src/+/2067862/ > > Change-Id: Ib6fd24c16c295fb4211dc295268af1e6f7f3fc45 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283661 > Reviewed-by: Florin Malita <[email protected]> > Commit-Queue: Mike Reed <[email protected]> [email protected],[email protected] Change-Id: I7c8cf2bc67aa267d442d0ca663e8378aa8feb409 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283896 Reviewed-by: Mike Reed <[email protected]> Commit-Queue: Mike Reed <[email protected]>
1 parent a6fbe4e commit 938b453

File tree

5 files changed

+186
-197
lines changed

5 files changed

+186
-197
lines changed

gn/tests.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ tests_sources = [
142142
"$_tests/LRUCacheTest.cpp",
143143
"$_tests/LayerDrawLooperTest.cpp",
144144
"$_tests/LazyProxyTest.cpp",
145-
"$_tests/M44Test.cpp",
146145
"$_tests/MD5Test.cpp",
147146
"$_tests/MallocPixelRefTest.cpp",
148147
"$_tests/MaskCacheTest.cpp",

include/core/SkMatrix44.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
#include "include/core/SkMatrix.h"
1212
#include "include/core/SkScalar.h"
1313

14-
#ifdef SK_SUPPORT_LEGACY_MATRIX44
15-
1614
#include <atomic>
1715
#include <cstring>
1816

@@ -392,4 +390,3 @@ class SK_API SkMatrix44 {
392390
};
393391

394392
#endif
395-
#endif

src/core/SkMatrix44.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
#include <type_traits>
1010
#include <utility>
1111

12-
#ifdef SK_SUPPORT_LEGACY_MATRIX44
13-
1412
// Copying SkMatrix44 byte-wise is performance-critical to Blink. This class is
1513
// contained in several Transform classes, which are copied multiple times
1614
// during the rendering life cycle. See crbug.com/938563 for reference.
@@ -999,5 +997,3 @@ SkMatrix44::operator SkMatrix() const {
999997

1000998
return dst;
1001999
}
1002-
1003-
#endif

tests/M44Test.cpp

Lines changed: 0 additions & 186 deletions
This file was deleted.

0 commit comments

Comments
 (0)