Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 999797a

Browse files
[Impeller] disable Adreno 506. (#56210)
Fixes flutter/flutter#155185
1 parent 795b549 commit 999797a

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

impeller/renderer/backend/vulkan/driver_info_vk.cc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,13 +338,17 @@ bool DriverInfoVK::IsKnownBadDriver() const {
338338
if (adreno_gpu_.has_value()) {
339339
auto adreno = adreno_gpu_.value();
340340
switch (adreno) {
341-
// see:
341+
// See:
342342
// https://github.com/flutter/flutter/issues/154103
343343
//
344344
// Reports "VK_INCOMPLETE" when compiling certain entity shader with
345345
// vkCreateGraphicsPipelines, which is not a valid return status.
346346
// See https://github.com/flutter/flutter/issues/155185 .
347347
case AdrenoGPU::kAdreno630:
348+
// See:
349+
// https://github.com/flutter/flutter/issues/155185
350+
// Unknown crashes but device is not easily acquirable.
351+
case AdrenoGPU::kAdreno506:
348352
return true;
349353
default:
350354
return false;

impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,10 @@ TEST(DriverInfoVKTest, EnabledDevicesAdreno) {
126126
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 512"));
127127
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 509"));
128128
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 508"));
129-
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 506"));
130129
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 505"));
131130
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 504"));
131+
132+
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 506"));
132133
}
133134

134135
} // namespace impeller::testing

0 commit comments

Comments
 (0)