Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9ccf9f1

Browse files
bring back build_test to ensure we validate licenses (#22201)
* add license check to cirrus config * update license goldens file
1 parent fd94c86 commit 9ccf9f1

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

.cirrus.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,8 @@ task:
6868
test_framework_script: |
6969
cd $FRAMEWORK_PATH/flutter/packages/flutter
7070
../../bin/flutter test --local-engine=host_debug_unopt --null-assertions --sound-null-safety --enable-experiment=non-nullable
71+
# TODO(fujino): remove this once ci/licenses.sh is run on LUCI
72+
- name: licenses_check
73+
build_script: |
74+
cd $ENGINE_PATH/src/flutter
75+
./ci/licenses.sh

ci/licenses_golden/licenses_flutter

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ FILE: ../../../flutter/fml/log_settings.h
158158
FILE: ../../../flutter/fml/log_settings_state.cc
159159
FILE: ../../../flutter/fml/logging.cc
160160
FILE: ../../../flutter/fml/logging.h
161+
FILE: ../../../flutter/fml/logging_unittests.cc
161162
FILE: ../../../flutter/fml/macros.h
162163
FILE: ../../../flutter/fml/make_copyable.h
163164
FILE: ../../../flutter/fml/mapping.cc
@@ -463,9 +464,6 @@ FILE: ../../../flutter/lib/web_ui/lib/src/engine/dom_canvas.dart
463464
FILE: ../../../flutter/lib/web_ui/lib/src/engine/dom_renderer.dart
464465
FILE: ../../../flutter/lib/web_ui/lib/src/engine/engine_canvas.dart
465466
FILE: ../../../flutter/lib/web_ui/lib/src/engine/frame_reference.dart
466-
FILE: ../../../flutter/lib/web_ui/lib/src/engine/history/history.dart
467-
FILE: ../../../flutter/lib/web_ui/lib/src/engine/history/js_url_strategy.dart
468-
FILE: ../../../flutter/lib/web_ui/lib/src/engine/history/url_strategy.dart
469467
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/backdrop_filter.dart
470468
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/canvas.dart
471469
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/clip.dart
@@ -499,6 +497,9 @@ FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/transform.dart
499497
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html_image_codec.dart
500498
FILE: ../../../flutter/lib/web_ui/lib/src/engine/keyboard.dart
501499
FILE: ../../../flutter/lib/web_ui/lib/src/engine/mouse_cursor.dart
500+
FILE: ../../../flutter/lib/web_ui/lib/src/engine/navigation/history.dart
501+
FILE: ../../../flutter/lib/web_ui/lib/src/engine/navigation/js_url_strategy.dart
502+
FILE: ../../../flutter/lib/web_ui/lib/src/engine/navigation/url_strategy.dart
502503
FILE: ../../../flutter/lib/web_ui/lib/src/engine/onscreen_logging.dart
503504
FILE: ../../../flutter/lib/web_ui/lib/src/engine/picture.dart
504505
FILE: ../../../flutter/lib/web_ui/lib/src/engine/platform_dispatcher.dart
@@ -586,6 +587,8 @@ FILE: ../../../flutter/runtime/dart_vm_unittests.cc
586587
FILE: ../../../flutter/runtime/embedder_resources.cc
587588
FILE: ../../../flutter/runtime/embedder_resources.h
588589
FILE: ../../../flutter/runtime/fixtures/runtime_test.dart
590+
FILE: ../../../flutter/runtime/isolate_configuration.cc
591+
FILE: ../../../flutter/runtime/isolate_configuration.h
589592
FILE: ../../../flutter/runtime/platform_data.cc
590593
FILE: ../../../flutter/runtime/platform_data.h
591594
FILE: ../../../flutter/runtime/ptrace_check.cc
@@ -600,6 +603,7 @@ FILE: ../../../flutter/runtime/skia_concurrent_executor.cc
600603
FILE: ../../../flutter/runtime/skia_concurrent_executor.h
601604
FILE: ../../../flutter/runtime/test_font_data.cc
602605
FILE: ../../../flutter/runtime/test_font_data.h
606+
FILE: ../../../flutter/runtime/type_conversions_unittests.cc
603607
FILE: ../../../flutter/shell/common/animator.cc
604608
FILE: ../../../flutter/shell/common/animator.h
605609
FILE: ../../../flutter/shell/common/animator_unittests.cc
@@ -615,8 +619,6 @@ FILE: ../../../flutter/shell/common/engine_unittests.cc
615619
FILE: ../../../flutter/shell/common/fixtures/shell_test.dart
616620
FILE: ../../../flutter/shell/common/fixtures/shelltest_screenshot.png
617621
FILE: ../../../flutter/shell/common/input_events_unittests.cc
618-
FILE: ../../../flutter/shell/common/isolate_configuration.cc
619-
FILE: ../../../flutter/shell/common/isolate_configuration.h
620622
FILE: ../../../flutter/shell/common/persistent_cache.cc
621623
FILE: ../../../flutter/shell/common/persistent_cache.h
622624
FILE: ../../../flutter/shell/common/persistent_cache_unittests.cc
@@ -636,6 +638,7 @@ FILE: ../../../flutter/shell/common/serialization_callbacks.h
636638
FILE: ../../../flutter/shell/common/shell.cc
637639
FILE: ../../../flutter/shell/common/shell.h
638640
FILE: ../../../flutter/shell/common/shell_benchmarks.cc
641+
FILE: ../../../flutter/shell/common/shell_fuchsia_unittests.cc
639642
FILE: ../../../flutter/shell/common/shell_io_manager.cc
640643
FILE: ../../../flutter/shell/common/shell_io_manager.h
641644
FILE: ../../../flutter/shell/common/shell_test.cc
@@ -907,6 +910,8 @@ FILE: ../../../flutter/shell/platform/common/cpp/public/flutter_plugin_registrar
907910
FILE: ../../../flutter/shell/platform/common/cpp/text_input_model.cc
908911
FILE: ../../../flutter/shell/platform/common/cpp/text_input_model.h
909912
FILE: ../../../flutter/shell/platform/common/cpp/text_input_model_unittests.cc
913+
FILE: ../../../flutter/shell/platform/common/cpp/text_range.h
914+
FILE: ../../../flutter/shell/platform/common/cpp/text_range_unittests.cc
910915
FILE: ../../../flutter/shell/platform/darwin/common/buffer_conversions.h
911916
FILE: ../../../flutter/shell/platform/darwin/common/buffer_conversions.mm
912917
FILE: ../../../flutter/shell/platform/darwin/common/command_line.h
@@ -1272,6 +1277,7 @@ FILE: ../../../flutter/shell/platform/glfw/client_wrapper/include/flutter/flutte
12721277
FILE: ../../../flutter/shell/platform/glfw/client_wrapper/include/flutter/flutter_window.h
12731278
FILE: ../../../flutter/shell/platform/glfw/client_wrapper/include/flutter/flutter_window_controller.h
12741279
FILE: ../../../flutter/shell/platform/glfw/client_wrapper/include/flutter/plugin_registrar_glfw.h
1280+
FILE: ../../../flutter/shell/platform/glfw/client_wrapper/plugin_registrar_glfw_unittests.cc
12751281
FILE: ../../../flutter/shell/platform/glfw/event_loop.cc
12761282
FILE: ../../../flutter/shell/platform/glfw/event_loop.h
12771283
FILE: ../../../flutter/shell/platform/glfw/flutter_glfw.cc

0 commit comments

Comments
 (0)