Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit abb4f3a

Browse files
committed
Clarify file sharing flags in FML filesystem APIs on Windows
Use shared mode when requesting read access and exclusive mode for write access
1 parent 030950f commit abb4f3a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

fml/platform/win/file_win.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,11 @@ static DWORD GetDesiredAccessFlags(FilePermission permission) {
8585
static DWORD GetShareFlags(FilePermission permission) {
8686
switch (permission) {
8787
case FilePermission::kRead:
88-
return FILE_SHARE_READ;
88+
return FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE;
8989
case FilePermission::kWrite:
90-
return FILE_SHARE_WRITE;
90+
return 0;
9191
case FilePermission::kReadWrite:
92-
return FILE_SHARE_READ | FILE_SHARE_WRITE;
92+
return 0;
9393
}
9494
return FILE_SHARE_READ;
9595
}

0 commit comments

Comments
 (0)