license / tidy

Author: gaaclarke

ci/licenses_golden/excluded_files

@@ -140,6 +140,8 @@
 ../../../flutter/impeller/compiler/shader_bundle_unittests.cc
 ../../../flutter/impeller/compiler/switches_unittests.cc
 ../../../flutter/impeller/core/allocator_unittests.cc
+../../../flutter/impeller/display_list/dl_golden_unittests.cc
+../../../flutter/impeller/display_list/dl_golden_unittests.h
 ../../../flutter/impeller/display_list/dl_unittests.cc
 ../../../flutter/impeller/display_list/skia_conversions_unittests.cc
 ../../../flutter/impeller/docs

impeller/golden_tests/golden_playground_test.h

@@ -44,7 +44,7 @@ class GoldenPlaygroundTest
 
   bool OpenPlaygroundHere(AiksPlaygroundCallback callback);
 
-  bool OpenPlaygroundHere(sk_sp<flutter::DisplayList> list);
+  bool OpenPlaygroundHere(const sk_sp<flutter::DisplayList>& list);
 
   static bool ImGuiBegin(const char* name,
                          bool* p_open,

impeller/golden_tests/golden_playground_test_mac.cc

@@ -229,7 +229,7 @@ bool GoldenPlaygroundTest::OpenPlaygroundHere(
 }
 
 bool GoldenPlaygroundTest::OpenPlaygroundHere(
-    sk_sp<flutter::DisplayList> list) {
+    const sk_sp<flutter::DisplayList>& list) {
   DlDispatcher dispatcher;
   list->Dispatch(dispatcher);
   Picture picture = dispatcher.EndRecordingAsPicture();

impeller/golden_tests/golden_playground_test_stub.cc

@@ -38,7 +38,7 @@ bool GoldenPlaygroundTest::OpenPlaygroundHere(
 }
 
 bool GoldenPlaygroundTest::OpenPlaygroundHere(
-    sk_sp<flutter::DisplayList> list) {
+    const sk_sp<flutter::DisplayList>& list) {
   return false;
 }