Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c6f26e0

Browse files
authored
Update display_list_image_filter_unittests to be permit Skia roll (#37327)
* Update display_list_image_filter_unittests to be permit Skia roll https://skia-review.googlesource.com/c/skia/+/571798 had to be reverted because it causes DisplayListImageFilter.LocalImageFilterBounds to fail. With SkMatrixTransformImageFilter (returned by SkImageFilters::MatrixTransform) supporting complex matrices, makeWithLocalMatrix(rotation) will no longer return null. This is at odds with the behavior of DlImageFilter's implementation which tries to mimic the existing behavior of image filters. This relaxes the test case so that Skia can improve its implementation without breaking Flutter's tests. Flutter can then update DlImageFilter to match out-of-band. * Update comment to reference flutter issue.
1 parent 0af8707 commit c6f26e0

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

display_list/display_list_image_filter_unittests.cc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -810,8 +810,11 @@ TEST(DisplayListImageFilter, LocalImageFilterBounds) {
810810
auto sk_local_filter = sk_filters[i]->makeWithLocalMatrix(m);
811811
auto dl_local_filter = dl_filters[i]->makeWithLocalMatrix(m);
812812
if (!sk_local_filter || !dl_local_filter) {
813-
ASSERT_TRUE(!sk_local_filter);
814-
ASSERT_TRUE(!dl_local_filter);
813+
// Temporarily relax the equivalence testing to allow Skia to expand
814+
// their behavior. Once the Skia fixes are rolled in, the
815+
// DlImageFilter should adapt to the new rules.
816+
// See https://github.com/flutter/flutter/issues/114723
817+
ASSERT_TRUE(sk_local_filter || !dl_local_filter);
815818
continue;
816819
}
817820
{

0 commit comments

Comments
 (0)