Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d5eb464

Browse files
committed
moved the golden test runner to the profile build
1 parent 6a73325 commit d5eb464

File tree

2 files changed

+27
-13
lines changed

2 files changed

+27
-13
lines changed

ci/builders/mac_host_engine.json

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,6 @@
143143
"cpu=x86",
144144
"mac_model=Macmini8,1"
145145
],
146-
"dependencies": [
147-
{
148-
"dependency": "goldctl",
149-
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
150-
}
151-
],
152146
"gclient_variables": {
153147
"download_android_deps": false
154148
},
@@ -169,7 +163,6 @@
169163
"flutter/build/archives:archive_gen_snapshot",
170164
"flutter/build/archives:artifacts",
171165
"flutter/build/dart:copy_dart_sdk",
172-
"flutter/impeller/golden_tests:impeller_golden_tests",
173166
"flutter/shell/platform/darwin/macos:zip_macos_flutter_framework",
174167
"flutter/tools/font_subset",
175168
"flutter:unittests"
@@ -183,13 +176,13 @@
183176
"tests": [
184177
{
185178
"language": "python3",
186-
"name": "Impeller-golden, dart and engine tests for host_release",
179+
"name": "dart and engine tests for host_release",
187180
"script": "flutter/testing/run_tests.py",
188181
"parameters": [
189182
"--variant",
190183
"host_release",
191184
"--type",
192-
"dart,dart-host,engine,impeller-golden"
185+
"dart,dart-host,engine"
193186
]
194187
}
195188
]
@@ -259,6 +252,12 @@
259252
"os=Mac-13",
260253
"cpu=x86"
261254
],
255+
"dependencies": [
256+
{
257+
"dependency": "goldctl",
258+
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
259+
}
260+
],
262261
"gclient_variables": {
263262
"download_android_deps": false
264263
},
@@ -269,21 +268,38 @@
269268
"--runtime-mode",
270269
"profile",
271270
"--no-lto",
272-
"--prebuilt-dart-sdk"
271+
"--prebuilt-dart-sdk",
272+
"--enable-impeller-vulkan",
273+
"--enable-impeller-opengles",
274+
"--use-glfw-swiftshader"
273275
],
274276
"name": "mac_profile_arm64",
275277
"ninja": {
276278
"config": "mac_profile_arm64",
277279
"targets": [
278280
"flutter/build/archives:artifacts",
281+
"flutter/impeller/golden_tests:impeller_golden_tests",
279282
"flutter/shell/platform/darwin/macos:zip_macos_flutter_framework"
280283
]
281284
},
282285
"properties": {
283286
"$flutter/osx_sdk": {
284287
"sdk_version": "15a240d"
285288
}
286-
}
289+
},
290+
"tests": [
291+
{
292+
"language": "python3",
293+
"name": "Impeller-golden",
294+
"script": "flutter/testing/run_tests.py",
295+
"parameters": [
296+
"--variant",
297+
"host_profile",
298+
"--type",
299+
"impeller-golden"
300+
]
301+
}
302+
]
287303
},
288304
{
289305
"archives": [

impeller/tools/impeller.gni

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ declare_args() {
5454
}
5555

5656
declare_args() {
57-
impeller_enable_validation = impeller_debug
58-
5957
# Wether to build and include the validation layers.
6058
impeller_enable_vulkan_validation_layers =
6159
impeller_enable_vulkan && flutter_runtime_mode == "debug" &&

0 commit comments

Comments
 (0)