Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d6ddc31

Browse files
authored
Added assertion up to cv99 for FontFeature.characterVariant (#27745)
* Added assertion up to cv99 for FontFeature.characterVariant * Added FontFeature.characterVariant(99) test
1 parent eb1d87d commit d6ddc31

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

lib/ui/text.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ class FontFeature {
472472
/// * <https://docs.microsoft.com/en-us/typography/opentype/spec/features_ae#cv01-cv99>
473473
factory FontFeature.characterVariant(int value) {
474474
assert(value >= 1);
475-
assert(value <= 20);
475+
assert(value <= 99);
476476
return FontFeature('cv${value.toString().padLeft(2, "0")}');
477477
}
478478

testing/dart/text_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ void testFontFeatureClass() {
198198
expect(const FontFeature.caseSensitiveForms(), const FontFeature('case', 1));
199199
expect( FontFeature.characterVariant(1), const FontFeature('cv01', 1));
200200
expect( FontFeature.characterVariant(18), const FontFeature('cv18', 1));
201+
expect( FontFeature.characterVariant(99), const FontFeature('cv99', 1));
201202
expect(const FontFeature.denominator(), const FontFeature('dnom', 1));
202203
expect(const FontFeature.fractions(), const FontFeature('frac', 1));
203204
expect(const FontFeature.historicalForms(), const FontFeature('hist', 1));

0 commit comments

Comments
 (0)