Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e29b552

Browse files
authored
Update gni filegroup when building Skia's codec files (#54588)
This was added in https://skia-review.googlesource.com/c/skia/+/890319 and Skia plans to delete the old group. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 52621de commit e29b552

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

skia/BUILD.gn

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,7 @@ skia_component("skia") {
638638
sources += skia_effects_sources
639639
sources += skia_colorfilters_sources
640640
sources += skia_effects_imagefilter_sources
641-
sources += skia_codec_core
641+
sources += skia_codec_shared
642642
sources += skia_codec_decode_bmp
643643
sources += skia_encode_srcs
644644
sources += skia_sksl_core_sources
@@ -649,8 +649,6 @@ skia_component("skia") {
649649
"$_skia_root/src/android/SkAnimatedImage.cpp",
650650
"$_skia_root/src/codec/SkAndroidCodec.cpp",
651651
"$_skia_root/src/codec/SkAndroidCodecAdapter.cpp",
652-
"$_skia_root/src/codec/SkEncodedInfo.cpp",
653-
"$_skia_root/src/codec/SkParseEncodedOrigin.cpp",
654652
"$_skia_root/src/codec/SkSampledCodec.cpp",
655653
"$_skia_root/src/ports/SkDiscardableMemory_none.cpp",
656654
"$_skia_root/src/ports/SkMemory_malloc.cpp",

0 commit comments

Comments
 (0)