Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f7668af

Browse files
authored
Move lint suppression from baseline.xml to @SuppressLint. (#55447)
I think you just had the lint identifier wrong? Closes flutter/flutter#155712.
1 parent 62c0e50 commit f7668af

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

shell/platform/android/io/flutter/embedding/android/FlutterView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ private int guessBottomKeyboardInset(WindowInsets insets) {
683683
// The annotations to suppress "InlinedApi" and "NewApi" lints prevent lint warnings
684684
// caused by usage of Android Q APIs. These calls are safe because they are
685685
// guarded.
686-
@SuppressLint({"InlinedApi", "NewApi"})
686+
@SuppressLint({"InlinedApi", "NewApi", "DeprecatedSinceApi"})
687687
@NonNull
688688
public final WindowInsets onApplyWindowInsets(@NonNull WindowInsets insets) {
689689
WindowInsets newInsets = super.onApplyWindowInsets(insets);

tools/android_lint/baseline.xml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<issues format="6" by="lint 8.3.0 [11479570] " type="baseline" client="" dependencies="true" name="" variant="all" version="8.3.0 [11479570] ">
33

4-
<issue
5-
id="DeprecatedSinceApi"
6-
message="This method is deprecated as of API level 30"
7-
errorLine1=" zeroSides = calculateShouldZeroSides();"
8-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
9-
<location
10-
file="../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java"
11-
line="759"
12-
column="21"/>
13-
</issue>
14-
154
<issue
165
id="HardcodedDebugMode"
176
message="Avoid hardcoding the debug mode; leaving it out allows debug and release builds to automatically assign one"

0 commit comments

Comments
 (0)