Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit ff07e57

Browse files
chinmaygardechinmaygarde
authored
[Impeller] libImpeller: Publish SDK artifacts. (#55783)
Fixes flutter/flutter#156358
1 parent 590babc commit ff07e57

File tree

6 files changed

+71
-9
lines changed

6 files changed

+71
-9
lines changed

‎BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ group("flutter") {
155155

156156
# Build the standalone Impeller library.
157157
if (is_mac || is_linux || is_win || is_android) {
158-
public_deps += [ "//flutter/impeller/toolkit/interop:library" ]
158+
public_deps += [ "//flutter/impeller/toolkit/interop:sdk" ]
159159
}
160160

161161
if ((flutter_runtime_mode == "debug" || flutter_runtime_mode == "profile") &&

‎ci/builders/linux_android_debug_engine.json

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"base_path": "out/ci/android_debug/zip_archives/",
5757
"include_paths": [
5858
"out/ci/android_debug/zip_archives/android-arm/artifacts.zip",
59+
"out/ci/android_debug/zip_archives/android-arm/impeller_sdk.zip",
5960
"out/ci/android_debug/zip_archives/android-arm/symbols.zip",
6061
"out/ci/android_debug/zip_archives/download.flutter.io",
6162
"out/ci/android_debug/zip_archives/sky_engine.zip",
@@ -90,7 +91,8 @@
9091
"flutter/sky/dist:zip_old_location",
9192
"flutter/lib/gpu/dist:zip_old_location",
9293
"flutter/shell/platform/android:embedding_jars",
93-
"flutter/shell/platform/android:abi_jars"
94+
"flutter/shell/platform/android:abi_jars",
95+
"flutter/impeller/toolkit/interop:sdk"
9496
]
9597
}
9698
},
@@ -102,6 +104,7 @@
102104
"base_path": "out/ci/android_debug_arm64/zip_archives/",
103105
"include_paths": [
104106
"out/ci/android_debug_arm64/zip_archives/android-arm64/artifacts.zip",
107+
"out/ci/android_debug_arm64/zip_archives/android-arm64/impeller_sdk.zip",
105108
"out/ci/android_debug_arm64/zip_archives/android-arm64/symbols.zip",
106109
"out/ci/android_debug_arm64/zip_archives/download.flutter.io"
107110
],
@@ -130,7 +133,8 @@
130133
"config": "ci/android_debug_arm64",
131134
"targets": [
132135
"flutter",
133-
"flutter/shell/platform/android:abi_jars"
136+
"flutter/shell/platform/android:abi_jars",
137+
"flutter/impeller/toolkit/interop:sdk"
134138
]
135139
}
136140
},
@@ -142,6 +146,7 @@
142146
"base_path": "out/ci/android_debug_x86/zip_archives/",
143147
"include_paths": [
144148
"out/ci/android_debug_x86/zip_archives/android-x86/artifacts.zip",
149+
"out/ci/android_debug_x86/zip_archives/android-x86/impeller_sdk.zip",
145150
"out/ci/android_debug_x86/zip_archives/android-x86/symbols.zip",
146151
"out/ci/android_debug_x86/zip_archives/download.flutter.io"
147152
],
@@ -170,7 +175,8 @@
170175
"config": "ci/android_debug_x86",
171176
"targets": [
172177
"flutter",
173-
"flutter/shell/platform/android:abi_jars"
178+
"flutter/shell/platform/android:abi_jars",
179+
"flutter/impeller/toolkit/interop:sdk"
174180
]
175181
}
176182
},
@@ -182,6 +188,7 @@
182188
"base_path": "out/ci/android_debug_x64/zip_archives/",
183189
"include_paths": [
184190
"out/ci/android_debug_x64/zip_archives/android-x64/artifacts.zip",
191+
"out/ci/android_debug_x64/zip_archives/android-x64/impeller_sdk.zip",
185192
"out/ci/android_debug_x64/zip_archives/android-x64/symbols.zip",
186193
"out/ci/android_debug_x64/zip_archives/download.flutter.io"
187194
],
@@ -210,7 +217,8 @@
210217
"config": "ci/android_debug_x64",
211218
"targets": [
212219
"flutter",
213-
"flutter/shell/platform/android:abi_jars"
220+
"flutter/shell/platform/android:abi_jars",
221+
"flutter/impeller/toolkit/interop:sdk"
214222
]
215223
}
216224
}

‎ci/builders/linux_host_engine.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"type": "gcs",
1717
"include_paths": [
1818
"out/ci/host_debug/zip_archives/linux-x64/artifacts.zip",
19+
"out/ci/host_debug/zip_archives/linux-x64/impeller_sdk.zip",
1920
"out/ci/host_debug/zip_archives/linux-x64/linux-x64-embedder.zip",
2021
"out/ci/host_debug/zip_archives/linux-x64/font-subset.zip",
2122
"out/ci/host_debug/zip_archives/flutter_patched_sdk.zip",
@@ -54,7 +55,8 @@
5455
"flutter/build/archives:embedder",
5556
"flutter/build/archives:flutter_patched_sdk",
5657
"flutter/build/dart:copy_dart_sdk",
57-
"flutter/tools/font_subset"
58+
"flutter/tools/font_subset",
59+
"flutter/impeller/toolkit/interop:sdk"
5860
]
5961
},
6062
"tests": [

‎ci/builders/mac_host_engine.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
"type": "gcs",
7373
"include_paths": [
7474
"out/ci/host_debug/zip_archives/darwin-x64/artifacts.zip",
75+
"out/ci/host_debug/zip_archives/darwin-x64/impeller_sdk.zip",
7576
"out/ci/host_debug/zip_archives/dart-sdk-darwin-x64.zip"
7677
],
7778
"name": "ci/host_debug",
@@ -108,7 +109,8 @@
108109
"config": "ci/host_debug",
109110
"targets": [
110111
"flutter/build/archives:artifacts",
111-
"flutter/build/archives:dart_sdk_archive"
112+
"flutter/build/archives:dart_sdk_archive",
113+
"flutter/impeller/toolkit/interop:sdk"
112114
]
113115
},
114116
"postsubmit_overrides": {
@@ -529,6 +531,7 @@
529531
"type": "gcs",
530532
"include_paths": [
531533
"out/ci/mac_debug_arm64/zip_archives/darwin-arm64/artifacts.zip",
534+
"out/ci/mac_debug_arm64/zip_archives/darwin-arm64/impeller_sdk.zip",
532535
"out/ci/mac_debug_arm64/zip_archives/dart-sdk-darwin-arm64.zip"
533536
],
534537
"name": "ci/mac_debug_arm64",
@@ -565,7 +568,8 @@
565568
"config": "ci/mac_debug_arm64",
566569
"targets": [
567570
"flutter/build/archives:artifacts",
568-
"flutter/build/archives:dart_sdk_archive"
571+
"flutter/build/archives:dart_sdk_archive",
572+
"flutter/impeller/toolkit/interop:sdk"
569573
]
570574
},
571575
"postsubmit_overrides": {

‎ci/builders/windows_host_engine.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
"type": "gcs",
88
"include_paths": [
99
"out/ci/host_debug/zip_archives/windows-x64/artifacts.zip",
10+
"out/ci/host_debug/zip_archives/windows-x64/impeller_sdk.zip",
1011
"out/ci/host_debug/zip_archives/windows-x64/windows-x64-embedder.zip",
1112
"out/ci/host_debug/zip_archives/windows-x64/font-subset.zip",
1213
"out/ci/host_debug/zip_archives/dart-sdk-windows-x64.zip",
@@ -46,7 +47,8 @@
4647
"flutter/tools/font_subset",
4748
"flutter/build/archives:dart_sdk_archive",
4849
"flutter/shell/platform/windows/client_wrapper:client_wrapper_archive",
49-
"flutter/build/archives:windows_flutter"
50+
"flutter/build/archives:windows_flutter",
51+
"flutter/impeller/toolkit/interop:sdk"
5052
]
5153
},
5254
"tests": [

‎impeller/toolkit/interop/BUILD.gn

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# Use of this source code is governed by a BSD-style license that can be
33
# found in the LICENSE file.
44

5+
import("//flutter/build/zip_bundle.gni")
56
import("//flutter/impeller/tools/impeller.gni")
67

78
embed_blob("embedded_icu_data") {
@@ -106,3 +107,48 @@ impeller_component("interop_unittests") {
106107
"//flutter/testing:testing_lib",
107108
]
108109
}
110+
111+
zip_bundle("sdk") {
112+
if (is_mac) {
113+
zip_out_dir = "darwin-${target_cpu}"
114+
} else {
115+
zip_out_dir = "${full_target_platform_name}"
116+
}
117+
118+
output = "${zip_out_dir}/impeller_sdk.zip"
119+
deps = [ ":library" ]
120+
121+
files = [
122+
{
123+
source = "impeller.h"
124+
destination = "include/impeller.h"
125+
},
126+
]
127+
128+
if (is_mac) {
129+
files += [
130+
{
131+
source = "$root_build_dir/libimpeller.dylib"
132+
destination = "lib/libimpeller.dylib"
133+
},
134+
]
135+
} else if (is_linux || is_android) {
136+
files += [
137+
{
138+
source = "$root_build_dir/libimpeller.so"
139+
destination = "lib/libimpeller.so"
140+
},
141+
]
142+
} else if (is_win) {
143+
files += [
144+
{
145+
source = "$root_build_dir/impeller.dll"
146+
destination = "lib/impeller.dll"
147+
},
148+
{
149+
source = "$root_build_dir/impeller.dll.lib"
150+
destination = "lib/impeller.dll.lib"
151+
},
152+
]
153+
}
154+
}

0 commit comments

Comments
 (0)