From 6b6bb4f062f440f4ae8f933d047db23f515192e8 Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Wed, 26 Aug 2020 15:51:37 -0700 Subject: [PATCH] Start an engine in ShellTest.OnServiceProtocolGetSkSLsWorks This test invokes a service protocol handler, and related methods such as Shell::GetServiceProtocolDescription make the assumption that an engine is available. See https://github.com/flutter/engine/pull/20142 --- shell/common/shell_unittests.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/shell/common/shell_unittests.cc b/shell/common/shell_unittests.cc index f368475d7a1d3..b451758667323 100644 --- a/shell/common/shell_unittests.cc +++ b/shell/common/shell_unittests.cc @@ -1636,6 +1636,10 @@ TEST_F(ShellTest, OnServiceProtocolGetSkSLsWorks) { Settings settings = CreateSettingsForFixture(); std::unique_ptr shell = CreateShell(settings); + auto configuration = RunConfiguration::InferFromSettings(settings); + configuration.SetEntrypoint("emptyMain"); + RunEngine(shell.get(), std::move(configuration)); + ServiceProtocol::Handler::ServiceProtocolMap empty_params; rapidjson::Document document; OnServiceProtocol(shell.get(), ServiceProtocolEnum::kGetSkSLs,