From 1f3e8fc7b389b171199b4cb6cc6c70fdb5e3a3b6 Mon Sep 17 00:00:00 2001 From: nturgut Date: Fri, 4 Dec 2020 14:20:54 -0800 Subject: [PATCH 1/2] sharding change is merged. re-enable tests --- lib/web_ui/dev/integration_tests_manager.dart | 44 +++---------------- 1 file changed, 5 insertions(+), 39 deletions(-) diff --git a/lib/web_ui/dev/integration_tests_manager.dart b/lib/web_ui/dev/integration_tests_manager.dart index 54056e49e3165..b077bdc174913 100644 --- a/lib/web_ui/dev/integration_tests_manager.dart +++ b/lib/web_ui/dev/integration_tests_manager.dart @@ -249,10 +249,9 @@ class IntegrationTestsManager { buildModes = {mode}; } } else { - // TODO(nurhan): Enable `release` when recipe is sharded. buildModes = _browser == 'chrome' - ? {'debug', 'profile'} - : {'profile'}; + ? {'debug', 'profile', 'release'} + : {'profile', 'release'}; } return buildModes; } @@ -632,28 +631,9 @@ const Map> blockedTestsListsMapForModes = 'treeshaking_integration.dart', 'text_editing_integration.dart', 'url_strategy_integration.dart', - - // TODO(yjbanov): https://github.com/flutter/flutter/issues/71583 - // The following tests are blocked to reduce the load on the build bot. - // The bot currently frequently exceeds the timeout limit. - 'image_loading_integration.dart', - 'platform_messages_integration.dart', - 'profile_diagnostics_integration.dart', - 'scroll_wheel_integration.dart', ], 'profile': [], - 'release': [ - // TODO(yjbanov): https://github.com/flutter/flutter/issues/71583 - // The following tests are blocked to reduce the load on the build bot. - // The bot currently frequently exceeds the timeout limit. - 'image_loading_integration.dart', - 'platform_messages_integration.dart', - 'profile_diagnostics_integration.dart', - 'scroll_wheel_integration.dart', - 'text_editing_integration.dart', - 'treeshaking_integration.dart', - 'url_strategy_integration.dart', - ], + 'release': [], }; /// Tests blocked for one of the rendering backends. @@ -663,24 +643,10 @@ const Map> blockedTestsListsMapForModes = // TODO(nurhan): Remove the failing test after fixing. const Map> blockedTestsListsMapForRenderBackends = >{ - 'auto': [ - 'image_loading_integration.dart', - 'platform_messages_integration.dart', - 'profile_diagnostics_integration.dart', - 'scroll_wheel_integration.dart', - 'text_editing_integration.dart', - 'treeshaking_integration.dart', - 'url_strategy_integration.dart', - ], + 'auto': [], 'html': [], // This test failed on canvaskit on all three build modes. 'canvaskit': [ - 'image_loading_integration.dart', - 'platform_messages_integration.dart', - 'profile_diagnostics_integration.dart', - 'scroll_wheel_integration.dart', - 'text_editing_integration.dart', - 'treeshaking_integration.dart', - 'url_strategy_integration.dart', + 'image_loading_integration', ], }; From 2351d1fcd8025f2e897c0fcd33065d28836217ca Mon Sep 17 00:00:00 2001 From: nturgut Date: Fri, 4 Dec 2020 15:32:49 -0800 Subject: [PATCH 2/2] fix file name for image loading. re-block auto --- lib/web_ui/dev/integration_tests_manager.dart | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/web_ui/dev/integration_tests_manager.dart b/lib/web_ui/dev/integration_tests_manager.dart index b077bdc174913..c75a8b9689a75 100644 --- a/lib/web_ui/dev/integration_tests_manager.dart +++ b/lib/web_ui/dev/integration_tests_manager.dart @@ -643,10 +643,18 @@ const Map> blockedTestsListsMapForModes = // TODO(nurhan): Remove the failing test after fixing. const Map> blockedTestsListsMapForRenderBackends = >{ - 'auto': [], + 'auto': [ + 'image_loading_integration.dart', + 'platform_messages_integration.dart', + 'profile_diagnostics_integration.dart', + 'scroll_wheel_integration.dart', + 'text_editing_integration.dart', + 'treeshaking_integration.dart', + 'url_strategy_integration.dart', + ], 'html': [], // This test failed on canvaskit on all three build modes. 'canvaskit': [ - 'image_loading_integration', + 'image_loading_integration.dart', ], };