This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[dart:ui] add documentation to FragmentShader setSampler/setFloat #37503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Nov 11, 2022
lib/ui/painting.dart
Outdated
| /// | ||
| /// ```glsl | ||
| /// uniform float uScale; | ||
| /// uniform int uPitch; |
There was a problem hiding this comment.
I'm not confident that int (or bool?) uniforms are properly supported yet. We'd at least want setInt() and setBool() methods, so that folks don't have to set int and bool uniforms using setFloat().
There was a problem hiding this comment.
They seem to "work" on skia, I'll dig into this a bit more for impeller
There was a problem hiding this comment.
Yeah this doesn't work when setting fields when we compiler for impellerc. I'll update this to leave them out for now.
zanderso
approved these changes
Nov 11, 2022
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 12, 2022
…115200) * b57e45ea5 [dart:ui] add documentation to FragmentShader setSampler/setFloat (flutter/engine#37503) * 4b559e6d8 Roll Skia from a727f7ac8a98 to b126902e7988 (1 revision) (flutter/engine#37547) * e3b3950f0 Revert "[dart:ui] add documentation to FragmentShader setSampler/setFloat (#37503)" (flutter/engine#37549)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…utter#37503) * [dart:ui] add documentation to FragmentShader setSampler/setFloat * remove int bool comments
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…loat (flutter#37503)" (flutter#37549) This reverts commit b57e45e.
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115200) * b57e45ea5 [dart:ui] add documentation to FragmentShader setSampler/setFloat (flutter/engine#37503) * 4b559e6d8 Roll Skia from a727f7ac8a98 to b126902e7988 (1 revision) (flutter/engine#37547) * e3b3950f0 Revert "[dart:ui] add documentation to FragmentShader setSampler/setFloat (flutter#37503)" (flutter/engine#37549)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115200) * b57e45ea5 [dart:ui] add documentation to FragmentShader setSampler/setFloat (flutter/engine#37503) * 4b559e6d8 Roll Skia from a727f7ac8a98 to b126902e7988 (1 revision) (flutter/engine#37547) * e3b3950f0 Revert "[dart:ui] add documentation to FragmentShader setSampler/setFloat (flutter#37503)" (flutter/engine#37549)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a bit confusing how the sampler/float index exactly maps to the order of uniforms in the shader program. Add some API docs to attempt to explain this, along with a code snippet.