[Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread #55398

jason-simmons · 2024-09-24T18:46:33Z

In the Vulkan backend, the CommandPoolRecyclerVK stores command pools that can be reused while rendering a frame. For each frame, SurfaceContextVK::AcquireNextSurface calls CommandPoolRecyclerVK::Dispose to clear the cached pools.

However, the CommandPoolRecyclerVK's cache of pools is placed in thread-local storage. So command pools used on the IO thread will not be cleaned up if frame rendering calls Dispose on the raster thread.

This PR adds a Context API that the IO thread can call after using a command pool in order to ensure that cached resources are disposed.

Fixes flutter/flutter#155519

…er decoding an image on the IO thread In the Vulkan backend, the CommandPoolRecyclerVK stores command pools that can be reused while rendering a frame. For each frame, SurfaceContextVK::AcquireNextSurface calls CommandPoolRecyclerVK::Dispose to clear the cached pools. However, the CommandPoolRecyclerVK's cache of pools is placed in thread-local storage. So command pools used on the IO thread will not be cleaned up if frame rendering calls Dispose on the raster thread. This PR adds a Context API that the IO thread can call after using a command pool in order to ensure that cached resources are disposed. Fixes flutter/flutter#155519

jonahwilliams

LGTM

gaaclarke

It would be nice if we had an integration test that made sure things get cleaned up after image decoding. I'm not sure how difficult that would be to pull off though.

…clerVK after decoding an image on the IO thread (flutter/engine#55398)

…155648) flutter/engine@559f2ff...746ce61 2024-09-25 [email protected] Roll Dart SDK from 7af8c4882e07 to eda9ae15367e (2 revisions) (flutter/engine#55417) 2024-09-25 [email protected] [Flutter GPU] Add CullMode. (flutter/engine#55409) 2024-09-25 [email protected] Roll Skia from 2e92f0b443f4 to 3541cdf2fae6 (1 revision) (flutter/engine#55412) 2024-09-24 [email protected] [Impeller] fix Impeller on windows. (flutter/engine#55323) 2024-09-24 [email protected] [Impeller] add basic culling checks during text frame dispatcher. (flutter/engine#55168) 2024-09-24 [email protected] Move each dart GN rule to a standalone file. (flutter/engine#55404) 2024-09-24 [email protected] Roll Skia from 118914b760cb to 2e92f0b443f4 (1 revision) (flutter/engine#55406) 2024-09-24 [email protected] [Impeller] Pack impeller:Path into 2 vecs instead of 3. (flutter/engine#55028) 2024-09-24 [email protected] Disallow time traveling frame times (flutter/engine#55310) 2024-09-24 [email protected] [Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread (flutter/engine#55398) 2024-09-24 [email protected] Roll Skia from cf28f9dd411d to 118914b760cb (1 revision) (flutter/engine#55405) 2024-09-24 [email protected] [Flutter GPU] Add pipeline stencil config. (flutter/engine#55272) 2024-09-24 [email protected] Roll Skia from 6e5ff9253147 to cf28f9dd411d (1 revision) (flutter/engine#55399) 2024-09-24 [email protected] [Impeller] delete expensive trace event. (flutter/engine#55400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#155648) flutter/engine@559f2ff...746ce61 2024-09-25 [email protected] Roll Dart SDK from 7af8c4882e07 to eda9ae15367e (2 revisions) (flutter/engine#55417) 2024-09-25 [email protected] [Flutter GPU] Add CullMode. (flutter/engine#55409) 2024-09-25 [email protected] Roll Skia from 2e92f0b443f4 to 3541cdf2fae6 (1 revision) (flutter/engine#55412) 2024-09-24 [email protected] [Impeller] fix Impeller on windows. (flutter/engine#55323) 2024-09-24 [email protected] [Impeller] add basic culling checks during text frame dispatcher. (flutter/engine#55168) 2024-09-24 [email protected] Move each dart GN rule to a standalone file. (flutter/engine#55404) 2024-09-24 [email protected] Roll Skia from 118914b760cb to 2e92f0b443f4 (1 revision) (flutter/engine#55406) 2024-09-24 [email protected] [Impeller] Pack impeller:Path into 2 vecs instead of 3. (flutter/engine#55028) 2024-09-24 [email protected] Disallow time traveling frame times (flutter/engine#55310) 2024-09-24 [email protected] [Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread (flutter/engine#55398) 2024-09-24 [email protected] Roll Skia from cf28f9dd411d to 118914b760cb (1 revision) (flutter/engine#55405) 2024-09-24 [email protected] [Flutter GPU] Add pipeline stencil config. (flutter/engine#55272) 2024-09-24 [email protected] Roll Skia from 6e5ff9253147 to cf28f9dd411d (1 revision) (flutter/engine#55399) 2024-09-24 [email protected] [Impeller] delete expensive trace event. (flutter/engine#55400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

jason-simmons requested review from jonahwilliams and gaaclarke September 24, 2024 18:46

github-actions bot added the e: impeller label Sep 24, 2024

jonahwilliams approved these changes Sep 24, 2024

View reviewed changes

gaaclarke approved these changes Sep 24, 2024

View reviewed changes

gaaclarke reviewed Sep 24, 2024

View reviewed changes

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2024

auto-submit bot merged commit a2cd9f4 into flutter:main Sep 24, 2024
32 checks passed

engine-flutter-autoroll mentioned this pull request Sep 25, 2024

Roll Flutter Engine from 559f2ff31c74 to 746ce6124844 (14 revisions) flutter/flutter#155648

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2024

a2cd9f4ce [Impeller] Delete command pools held by the CommandPoolRecy…

94267c5

…clerVK after decoding an image on the IO thread (flutter/engine#55398)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread #55398

[Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread #55398

Uh oh!

jason-simmons commented Sep 24, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

gaaclarke left a comment

Uh oh!

Uh oh!

Uh oh!

[Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread #55398

[Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread #55398

Uh oh!

Conversation

jason-simmons commented Sep 24, 2024

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!