This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fix initial layout for loadOp load and incorrect usage of host visible textures. #56148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2024 19:01
jonahwilliams
commented
Oct 26, 2024
|
|
||
| auto texture_descriptor = impeller::TextureDescriptor{}; | ||
| texture_descriptor.storage_mode = impeller::StorageMode::kHostVisible; | ||
| impeller::TextureDescriptor texture_descriptor; |
Contributor
Author
There was a problem hiding this comment.
Not really related but this was also tripping validation errors for me, because molten vk actually creates the linear texture but then we can't actually do anything with it.
| #include "impeller/core/formats.h" | ||
| #include "impeller/renderer/backend/vulkan/context_vk.h" | ||
| #include "impeller/renderer/backend/vulkan/vk.h" | ||
| #include "vulkan/vulkan_enums.hpp" |
Member
There was a problem hiding this comment.
Please include vk.h directly instead of this because it contains some defines that can mess up usage.
chinmaygarde
approved these changes
Oct 28, 2024
jonahwilliams
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/56148, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2024
… usage of host visible textures. (flutter/engine#56148)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 28, 2024
…157751) flutter/engine@70671ba...ed587dc 2024-10-28 [email protected] Roll Dart SDK from 69b50768d733 to c9180e9de9e8 (1 revision) (flutter/engine#56180) 2024-10-28 [email protected] [Impeller] fix initial layout for loadOp load and incorrect usage of host visible textures. (flutter/engine#56148) 2024-10-28 [email protected] Roll Skia from 21035cd95b68 to bdd225968dab (1 revision) (flutter/engine#56178) 2024-10-28 [email protected] iOS/macOS: migrate darwin/common to ARC (flutter/engine#56155) 2024-10-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pin local_engine mac builds to arm64 (#56172)" (flutter/engine#56179) 2024-10-28 [email protected] Migrate PlatformViewIOS to ARC (flutter/engine#55672) 2024-10-28 [email protected] Roll Skia from 35ad4e89212f to 21035cd95b68 (1 revision) (flutter/engine#56176) 2024-10-28 [email protected] Roll buildroot to pick up revert of debugging gen_snapshot prints (flutter/engine#56175) 2024-10-28 [email protected] Pin local_engine mac builds to arm64 (flutter/engine#56172) 2024-10-28 [email protected] Switch some mac_unopt tests from intel to arm hosts (flutter/engine#55882) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…host visible textures. (flutter/engine#56148) Both changes were required to get playground tests validation free with moltenvk. becuase an initial state of undefined means "I don't care what was in this texture before" but that doesn't make sense if we're setting "kLoad" since that explicitly asks vulkan to load the previous contents. Fixes flutter#157557
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both changes were required to get playground tests validation free with moltenvk. becuase an initial state of undefined means "I don't care what was in this texture before" but that doesn't make sense if we're setting "kLoad" since that explicitly asks vulkan to load the previous contents.
Fixes flutter/flutter#157557