Skip to content

Commit 383e872

Browse files
authored
Remove AndroidModuleLibraryManager and related files (#8778)
This code was never turned on by default (see conditional in `FlutterStudioStartupActivity`), so I think it is safe to remove. When I try to turn it on by setting `flutter.android.library.sync` to true in Help > "Set custom properties", there are additional errors from reflection classes. I think if we want to implement something to turn on automatic gradle syncing of Android code etc, it will require a different approach. I had to run `./gradlew clean` before being able to build and run (not sure if that was specific to my system). This will address a few boxes in #8764.
1 parent c4ae909 commit 383e872

6 files changed

Lines changed: 0 additions & 480 deletions

File tree

resources/META-INF/studio-contribs.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
<extensions defaultExtensionNs="com.intellij">
1010
<externalSystemTaskNotificationListener implementation="io.flutter.utils.FlutterExternalSystemTaskNotificationListener"/>
1111
<postStartupActivity implementation="io.flutter.FlutterStudioStartupActivity"/>
12-
<library.type implementation="io.flutter.android.AndroidModuleLibraryType"/>
13-
<projectService serviceImplementation="io.flutter.android.AndroidModuleLibraryManager"/>
1412

1513
</extensions>
1614

src/io/flutter/FlutterStudioStartupActivity.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@
1313
import com.intellij.openapi.module.Module;
1414
import com.intellij.openapi.project.Project;
1515
import com.intellij.util.concurrency.AppExecutorUtil;
16-
import io.flutter.android.AndroidModuleLibraryManager;
1716
import io.flutter.dart.FlutterDartAnalysisServer;
1817
import io.flutter.logging.PluginLogger;
19-
import io.flutter.settings.FlutterSettings;
2018
import io.flutter.utils.AddToAppUtils;
2119
import io.flutter.utils.AndroidUtils;
2220
import io.flutter.utils.FlutterModuleUtils;
@@ -41,12 +39,6 @@ private static Void doNonBlockingStartup(@NotNull Project project) {
4139
// Unset this flag for all projects, mainly to ease the upgrade from 3.0.1 to 3.1.
4240
// TODO(messick) Delete once 3.0.x has 0 7DA's.
4341
//FlutterProjectCreator.disableUserConfig(project);
44-
// Monitor Android dependencies.
45-
FlutterSettings flutterSettings = FlutterSettings.getInstance();
46-
if (flutterSettings.isSyncingAndroidLibraries() || System.getProperty("flutter.android.library.sync", null) != null) {
47-
// TODO(messick): Remove the flag once this sync mechanism is stable.
48-
AndroidModuleLibraryManager.startWatching(project);
49-
}
5042
return null;
5143
}
5244

src/io/flutter/android/AndroidModuleLibraryManager.java

Lines changed: 0 additions & 363 deletions
This file was deleted.

0 commit comments

Comments
 (0)