Skip to content

Commit 43cc44e

Browse files
authored
[verifier] migrate from to-be-removed SystemInfo.getOsNameAndVersion (#8774)
Scheduled from removal as of 2026.1. See: #8764 --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent f10d79e commit 43cc44e

4 files changed

Lines changed: 21 additions & 8 deletions

File tree

src/io/flutter/jxbrowser/JxBrowserManager.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import com.intellij.openapi.project.Project;
1616
import com.intellij.openapi.project.ProjectManager;
1717
import com.intellij.openapi.util.Pair;
18-
import com.intellij.openapi.util.SystemInfo;
1918
import com.intellij.util.containers.ContainerUtil;
2019
import com.intellij.util.download.DownloadableFileDescription;
2120
import com.intellij.util.download.DownloadableFileService;
@@ -26,6 +25,7 @@
2625
import io.flutter.settings.FlutterSettings;
2726
import io.flutter.utils.FileUtils;
2827
import io.flutter.utils.JxBrowserUtils;
28+
import io.flutter.utils.SystemUtils;
2929
import org.jetbrains.annotations.NotNull;
3030
import org.jetbrains.annotations.Nullable;
3131

@@ -36,7 +36,12 @@
3636
import java.lang.reflect.InvocationTargetException;
3737
import java.nio.file.Path;
3838
import java.nio.file.Paths;
39-
import java.util.*;
39+
import java.util.ArrayList;
40+
import java.util.Arrays;
41+
import java.util.Collections;
42+
import java.util.List;
43+
import java.util.Objects;
44+
import java.util.Optional;
4045
import java.util.concurrent.CompletableFuture;
4146
import java.util.concurrent.ExecutionException;
4247
import java.util.concurrent.TimeUnit;
@@ -211,8 +216,8 @@ public void setUp(@NotNull String projectName) {
211216
platformFileName = jxBrowserUtils.getPlatformFileName();
212217
}
213218
catch (FileNotFoundException e) {
214-
LOG.info(projectName + ": Unable to find JxBrowser platform file for " + SystemInfo.getOsNameAndVersion());
215-
setStatusFailed(new InstallationFailedReason(FailureType.MISSING_PLATFORM_FILES, SystemInfo.getOsNameAndVersion()));
219+
LOG.info(projectName + ": Unable to find JxBrowser platform file for " + SystemUtils.getOsNameAndVersion());
220+
setStatusFailed(new InstallationFailedReason(FailureType.MISSING_PLATFORM_FILES, SystemUtils.getOsNameAndVersion()));
216221
return;
217222
}
218223

src/io/flutter/run/daemon/DeviceDaemon.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import com.intellij.openapi.project.Project;
1717
import com.intellij.openapi.ui.DialogWrapper;
1818
import com.intellij.openapi.ui.Messages;
19-
import com.intellij.openapi.util.SystemInfo;
2019
import com.intellij.openapi.util.io.FileUtil;
2120
import com.intellij.openapi.util.text.StringUtil;
2221
import io.flutter.FlutterMessages;
@@ -32,10 +31,13 @@
3231
import io.flutter.utils.FlutterModuleUtils;
3332
import io.flutter.utils.MostlySilentColoredProcessHandler;
3433
import io.flutter.utils.OpenApiUtils;
34+
import io.flutter.utils.SystemUtils;
3535
import org.jetbrains.annotations.NotNull;
3636
import org.jetbrains.annotations.Nullable;
3737

38-
import javax.swing.*;
38+
import javax.swing.JComponent;
39+
import javax.swing.JPanel;
40+
import javax.swing.JTextPane;
3941
import java.io.File;
4042
import java.nio.charset.StandardCharsets;
4143
import java.util.ArrayList;
@@ -452,7 +454,7 @@ private static class DaemonCrashReporter extends DialogWrapper {
452454
setTitle("Flutter Device Daemon Crash");
453455
myPanel = new JPanel();
454456
myTextPane = new JTextPane();
455-
final String os = SystemInfo.getOsNameAndVersion();
457+
final String os = SystemUtils.getOsNameAndVersion();
456458
final String link = "https://www.google.com/search?q=increase maximum file handles " + os;
457459
Messages.installHyperlinkSupport(myTextPane);
458460
final String message =

src/io/flutter/utils/JxBrowserUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ else if (SystemInfo.isLinux && is64Bit) {
4545
}
4646

4747
if (name.isEmpty()) {
48-
throw new FileNotFoundException("Unable to find matching JxBrowser platform file for: " + SystemInfo.getOsNameAndVersion());
48+
throw new FileNotFoundException("Unable to find matching JxBrowser platform file for: " + SystemUtils.getOsNameAndVersion());
4949
}
5050

5151
return String.format("%s-%s-%s.%s", JXBROWSER_FILE_PREFIX, name, JXBROWSER_FILE_VERSION, JXBROWSER_FILE_SUFFIX);

src/io/flutter/utils/SystemUtils.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,18 @@
1212
import com.intellij.execution.util.ExecUtil;
1313
import com.intellij.openapi.util.SystemInfo;
1414
import com.intellij.util.concurrency.AppExecutorUtil;
15+
import com.intellij.util.system.OS;
1516
import org.jetbrains.annotations.Nullable;
1617

1718
import java.io.File;
1819
import java.util.concurrent.CompletableFuture;
1920

2021
public class SystemUtils {
22+
23+
// Replaces slated-for-removal `com.intellij.openapi.util.SystemInfo.getOsNameAndVersion()`.
24+
public static String getOsNameAndVersion() {
25+
return OS.CURRENT.name() + ' ' + OS.CURRENT.version;
26+
}
2127

2228
/**
2329
* Locate a given command-line tool given its name.

0 commit comments

Comments
 (0)