Merge branch 'main' into dependabot/github_actions/actions/upload-artifact-7

Author: pq

.aiconfig

@@ -0,0 +1,21 @@
+# Gemini Code Assist Configuration
+version: 1.0
+project:
+  context:
+    instruction_files:
+      - .gemini/styleguide.md
+
+  generation_rules:
+    - "Strictly adhere to the IntelliJ Platform Threading Model: No I/O on the EDT."
+    - "All generated AnAction classes must be stateless."
+    - "Apply [MUST-FIX], [CONCERN], and [NIT] severity logic to any code suggestions that violate plugin SDK best practices or style guidelines."
+    - "Use io.flutter.logging.PluginLogger for all logging; avoid System.out."
+    - "Always include the standard Chromium Authors copyright header in new files."
+    - "Adhere to the Zero-Formatting Policy: Do not comment on indentation, spacing, or brace placement."
+    # Ensure local agents read styleguide files automatically.
+    - "At the start of the session, read and adhere to the guidelines in all files listed in project.context.instruction_files."
+
+  languages:
+    - java
+    - kotlin
+    - dart 

.gemini/styleguide.md

@@ -1,49 +1,66 @@
 # Gemini Code Assist Flutter IntelliJ Plugin Style Guide
 
-You are an expert Java and Kotlin developer specializing in building on top of the IntelliJ Platform Plugin SDK. When reviewing pull requests for this repository, 
+You are an expert Java and Kotlin developer specializing in building on top of the IntelliJ Platform Plugin SDK. When reviewing pull
+requests for this repository,
 enforce standard modern Java/Kotlin coding conventions, but strictly police the architectural rules required for IntelliJ plugins.
 
 ## 1. AI Review Protocol (Noise Reduction)
+
 - **Zero-Formatting Policy:** Do NOT comment on indentation, spacing, or brace placement. We use `dart format` and IDE auto-formatters.
 - **Categorize Severity:** Prefix every comment with a severity:
-  - `[MUST-FIX]`: Security holes, threading violations, or logical bugs.
-  - `[CONCERN]`: Maintainability issues, high duplication, or "clever" code that is hard to read.
-  - `[NIT]`: Idiomatic improvements or minor naming suggestions.
+    - `[MUST-FIX]`: Security holes, threading violations, or logical bugs.
+    - `[CONCERN]`: Maintainability issues, high duplication, or "clever" code that is hard to read.
+    - `[NIT]`: Idiomatic improvements or minor naming suggestions.
 - **Focus:** Prioritize logic, performance on the UI thread, and architectural consistency.
 - **No Empty Praise:** Do not leave "Looks good" or "Nice change" comments. If there are no issues, leave no comments.
+- **Copyright Headers:** Ensure all new files have a proper copyright header (e.g., `Copyright 2026 The Chromium Authors`). Flag any missing
+  headers as `[MUST-FIX]`.
 
 ## 2. IntelliJ Platform Best Practices
+
 - **Threading Model:** - NEVER perform heavy operations (I/O, complex PSI searches) on the **Event Dispatch Thread (EDT)**.
-  - Wrap data access in `ReadAction.run()` or `ReadAction.compute()`.
-  - Wrap modifications in `WriteAction.run()`.
-  - In `AnAction`, ensure `getActionUpdateThread()` is implemented for 2022.3+ compatibility.
+    - Wrap data access in `ReadAction.run()` or `ReadAction.compute()`.
+    - Wrap modifications in `WriteAction.run()`.
+    - In `AnAction`, ensure `getActionUpdateThread()` is implemented for 2022.3+ compatibility.
 - **Performance:**
-  - In loops over PSI elements or Virtual Files, always call `ProgressManager.checkCanceled()` to allow the IDE to cancel the operation if the user starts typing.
+    - In loops over PSI elements or Virtual Files, always call `ProgressManager.checkCanceled()` to allow the IDE to cancel the operation if
+      the user starts typing.
 - **Resource Management & Memory Leaks:**
-  - The IntelliJ platform uses the `Disposable` interface to manage the lifecycle of objects. Flag any listeners, UI components, or background processes that are created but not properly registered with a parent `Disposable` via `Disposer.register()`.
-  - Flag the use of deprecated `ProjectComponent` or `ApplicationComponent`. Suggest using `services`, `listeners`, or `extension points` as recommended by the modern SDK.
+    - The IntelliJ platform uses the `Disposable` interface to manage the lifecycle of objects. Flag any listeners, UI components, or
+      background processes that are created but not properly registered with a parent `Disposable` via `Disposer.register()`.
+    - Flag the use of deprecated `ProjectComponent` or `ApplicationComponent`. Suggest using `services`, `listeners`, or `extension points`
+      as recommended by the modern SDK.
 - **Backward Compatibility:** Avoid using `@ApiStatus.Internal` or `@ApiStatus.ScheduledForRemoval` APIs unless strictly necessary.
 - **Logging:**
-  - Reject any use of `System.out.println` or `System.err.println` for logging.
-  - Enforce the use of the IntelliJ SDK's built-in logger: `com.intellij.openapi.diagnostic.Logger` or our own: `io.flutter.logging.PluginLogger.
+    - Reject any use of `System.out.println` or `System.err.println` for logging in `src/` code (integration tests may use them for
+      milestone logging).
+    - Enforce the use of the IntelliJ SDK's built-in logger (`com.intellij.openapi.diagnostic.Logger`) or our own (
+      `io.flutter.logging.PluginLogger`).
 - **Actions:**
-  - Classes extending `AnAction` must be completely stateless. Flag any `AnAction` class that defines mutable instance variables (fields), as the platform instantiates a single instance of the action for the lifetime of the IDE.
-  - Ensure `update(AnActionEvent e)` methods are fast and do not perform heavy calculations, as they are called frequently by the IDE to determine menu item visibility.
-  - Ensure `actionPerformed(AnActionEvent e)` methods are instrumented w/ a call to analytics reporting like `Analytics.report(AnalyticsData.forAction(this, e))`.
+    - Classes extending `AnAction` must be completely stateless. Flag any `AnAction` class that defines mutable instance variables (fields),
+      as the platform instantiates a single instance of the action for the lifetime of the IDE.
+    - Ensure `update(AnActionEvent e)` methods are fast and do not perform heavy calculations, as they are called frequently by the IDE to
+      determine menu item visibility.
+    - Ensure `actionPerformed(AnActionEvent e)` methods are instrumented w/ a call to analytics reporting like
+      `Analytics.report(AnalyticsData.forAction(this, e))`.
 
 ## 3. Idiomatic Language Standards
+
 ### Dart
+
 - Follow [Effective Dart](https://dart.dev/effective-dart).
 - **Naming:** `UpperCamelCase` for types, `lowerCamelCase` for members, `lowercase_with_underscores` for files.
 - **Concurrency:** Prefer `async/await` over raw `Future.then()`. Use `final` by default.
 
 ### Kotlin
+
 - **Immutability:** Prefer `val` over `var`. Use `data class` for state-holding objects.
 - **Scope Functions:** Use `.let`, `.apply`, and `.also` correctly to reduce temporary variables.
 - **Null Safety:** NEVER use the double-bang `!!` operator. Use `?.`, `?:`, or `if (x != null)`.
 - **Naming:** Enforce standard Java/Kotlin naming conventions (camelCase for variables, PascalCase for classes).
 
 ### Java (Modern)
+
 - Use **Switch Expressions** instead of multi-line `if/else` or old `switch` statements.
 - Use `java.util.Optional` for return types that may be empty; avoid returning `null`.
 - Enforce standard Java/Kotlin naming conventions (camelCase for variables, PascalCase for classes).
@@ -52,6 +69,9 @@ enforce standard modern Java/Kotlin coding conventions, but strictly police the
 - Avoid stray `TODO` or `FIXME` comments without justification.
 
 ## 4. Code Quality & Maintainability
+
 - **Single Responsibility:** Methods should ideally be 10-20 lines. If a method exceeds 30 lines, suggest a refactor.
 - **DRY:** Identify blocks of code that are 90%+ identical to existing utility methods in this repo and flag them for duplication.
 - **Meaningful Naming:** Variables should describe their intent (e.g., `timeoutInMs` instead of `t`).
+- **Descriptive Pull Request:** Contributors should include the information recommended in the pull request template (In
+  `.github/PULL_REQUEST_TEMPLATE.md`Ï)

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,14 +1,30 @@
-Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
+Thanks for your contribution! Please replace this text with:
+
+- a description of what this PR is changing and why
+- any relevant issues
+- a description of how to verify the change is working
+- screenshots/gif if relevant
 
 ---
 
+Review the contribution guidelines below:
+
 - [ ] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
+- [ ] I've included the required information in the description above.
+- [ ] My up-to-date information is in the `AUTHORS` file.
+- [ ] I've updated `CHANGELOG.md` if appropriate.
 
 <details>
   <summary>Contribution guidelines:</summary><br>
 
-- See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs.
+- See
+  our [contributor guide](../CONTRIBUTING.md) and
+  the [Flutter organization contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)
+  for general expectations for PRs.
 - Larger or significant changes should be discussed in an issue before creating a PR.
-- Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`.
-- Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](https://github.com/flutter/flutter-intellij/issues/8098)).
+- Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use
+  `dart format`.
+- Java and Kotlin contributions should strive to follow Java and Kotlin best
+  practices ([discussion](https://github.com/flutter/flutter-intellij/issues/8098)).
+
 </details>

AUTHORS

@@ -25,3 +25,6 @@ Eli Albert <crasowas@gmail.com>
 Mohamed El Sayed <devblooming@tutanota.com>
 Edwin Ludik <edwin.ludik@gmail.com>
 Japnit Singh <truejswalia@gmail.com>
+Dmitry Kandalov <dmitry.kandalov@gmail.com>
+Kazuya Chikamatsu <kazu.chika.shima@gmail.com>
+Dustin Feucht <code.nopjar@gmail.com>

CHANGELOG.md

@@ -2,11 +2,28 @@
 
 ### Added
 
+- Option to specify the pub root module for Flutter Widget Previewer. (#8888)
+
 ### Changed
 
 ### Removed
 
 ### Fixed
+- Silent failure when opening Flutter projects without `.idea` directory in IntelliJ IDEA, by removing `FlutterProjectOpenProcessor` and
+  migrating configuration logic to `FlutterInitializer`. (#8903)
+
+## 91.0.0
+
+### Changed
+
+- Gradle plugin version to re-enable running `./gradlew verifyPlugin` locally. (#8847)
+
+### Fixed
+
+- Gutter buttons not running tests with non-ASCII characters in their names. (#8838)
+- Freeze from JX Browser close. (#8864)
+- Crash in split debugger mode in IntelliJ 2025.3+. (#8878)
+- Passing additional arguments from the Flutter test template. (#8836)
 
 ## 90.0.0
 

CLAUDE.md

@@ -0,0 +1,12 @@
+# Flutter IntelliJ Plugin — Claude Code Guide
+
+@.gemini/styleguide.md
+
+## Additional Rules
+
+- No I/O or heavy computation on the EDT (IntelliJ Threading Model).
+- All `AnAction` subclasses must be stateless (no mutable instance fields).
+- Use `io.flutter.logging.PluginLogger` (or IntelliJ's `Logger`) for all logging; never `System.out`.
+- All new files must include the standard Chromium Authors copyright header.
+- Zero-Formatting Policy: do not comment on indentation, spacing, or brace placement.
+- Categorize code suggestions with `[MUST-FIX]`, `[CONCERN]`, or `[NIT]` severity prefixes.

CONTRIBUTING.md

@@ -58,7 +58,6 @@ name and contact info to the [AUTHORS](AUTHORS) file.
 ## Environment set-up
 
 1. Install the latest [Java Development Kit](https://www.java.com/en/download/).
-    - The current Java Development Kit version is: **23**.
     - **[Googlers only]** Install Java from go/softwarecenter instead.
 
 2. Set your `JAVA_HOME` directory in the configuration file for your shell environment.
@@ -233,6 +232,23 @@ name and contact info to the [AUTHORS](AUTHORS) file.
     - Expand `Edit configuration templates...` and verify that Flutter is present.
     - Click [+] and verify that Flutter is present.
 
+### Running against custom target IDEs
+
+To test or debug the plugin against a different IDE target (like IntelliJ IDEA Community or Ultimate) without changing the project's compilation target, you can use the custom `runTarget` Gradle task.
+
+Run it from the command line specifying the target IDE and version:
+```bash
+./gradlew runTarget -Pide=IntelliJ -PideV=2025.1
+```
+
+*   **`-Pide`**: Valid values are `AndroidStudio` (default), `IntelliJ` (Community), and `Ultimate`.
+*   **`-PideV`**: Any valid version string or build number for the selected IDE.
+
+To see a full list of available options and usage examples, run the task without any parameters:
+```bash
+./gradlew runTarget
+```
+
 ## Provision Tool
 
 This is not currently required. However, for debugging unit tests, it may be handy; please ignore for now.

build.gradle.kts

@@ -40,7 +40,7 @@ plugins {
   // https://plugins.gradle.org/plugin/org.jetbrains.intellij.platform
   // https://plugins.gradle.org/plugin/org.jetbrains.kotlin.jvm
   id("java") // Java support
-  id("org.jetbrains.intellij.platform") version "2.10.5" // IntelliJ Platform Gradle Plugin
+  id("org.jetbrains.intellij.platform") version "2.12.0" // IntelliJ Platform Gradle Plugin
   id("org.jetbrains.kotlin.jvm") version "2.2.0" // Kotlin support
   id("org.jetbrains.changelog") version "2.2.0" // Gradle Changelog Plugin
   id("org.jetbrains.kotlinx.kover") version "0.9.4"
@@ -389,12 +389,18 @@ tasks {
 // https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-faq.html#how-to-check-the-latest-available-eap-release
 tasks {
   printProductsReleases {
-    channels = listOf(ProductRelease.Channel.EAP)
-    types = listOf(IntelliJPlatformType.IntellijIdeaCommunity)
+    channels = listOf(ProductRelease.Channel.RELEASE, ProductRelease.Channel.EAP)
+    types = listOf(IntelliJPlatformType.IntellijIdeaCommunity, IntelliJPlatformType.IntellijIdeaUltimate)
     untilBuild = provider { null }
 
     doLast {
       productsReleases.get().max()
+      println()
+      println("Mapping printProductsReleases output to ideV:")
+      println(" - The prefix (e.g., IU-, IC-) maps to -Pide (Ultimate, IntelliJ).")
+      println(" - The number part (e.g., 261.23567.71) maps to -PideV.")
+      println(" - Example: IU-261.23567.71 -> -Pide=Ultimate -PideV=261.23567.71")
+      println()
     }
   }
   prepareJarSearchableOptions {
@@ -415,6 +421,53 @@ tasks {
   }
 }
 
+intellijPlatformTesting {
+  runIde {
+    register("runTarget") {
+      val target = project.findProperty("ide") as? String
+      val version = project.findProperty("ideV") as? String
+      
+      val actualTarget = target ?: "AndroidStudio"
+      type = when (actualTarget) {
+        "IntelliJ" -> IntelliJPlatformType.IntellijIdeaCommunity
+        "Ultimate" -> IntelliJPlatformType.IntellijIdeaUltimate
+        else -> IntelliJPlatformType.AndroidStudio
+      }
+      this.version = version ?: ideaVersion
+    }
+  }
+}
+
+tasks.named("runTarget") {
+  val target = project.findProperty("ide") as? String
+  val version = project.findProperty("ideV") as? String
+  
+  doFirst {
+    if (target == null && version == null) {
+      println("============================================================")
+      println("runTarget - Available Options")
+      println("============================================================")
+      println("Valid values for -Pide:")
+      println(" - AndroidStudio (default)")
+      println(" - IntelliJ (IntelliJ IDEA Community)")
+      println(" - Ultimate (IntelliJ IDEA Ultimate)")
+      println()
+      println("Valid values for -PideV:")
+      println(" - Any valid version string for the selected IDE.")
+      println(" - Examples for IntelliJ/Ultimate: 2024.1, 2024.2, 2024.3, 2025.1")
+      println(" - Run './gradlew printProductsReleases' to see the full list.")
+      println()
+      println("Examples:")
+      println(" ./gradlew runTarget -Pide=IntelliJ -PideV=2025.1")
+      println(" ./gradlew runTarget -Pide=Ultimate -PideV=2025.1")
+      println("============================================================")
+      println("Stopping execution. Please run with parameters to launch a specific IDE.")
+      
+      throw org.gradle.api.tasks.StopExecutionException()
+    }
+  }
+}
+
 // A task to print the classpath used for compiling an IntelliJ plugin
 // Run with `./gradlew printCompileClasspath --no-configuration-cache `
 tasks.register<Task>("printCompileClasspath") {

gradle.properties

@@ -5,7 +5,7 @@
 #
 
 ideaVersion=2025.2.3.9
-dartPluginVersion= 503.0.0
+dartPluginVersion= 504.0.0
 # Also update the versions for verify checks in tool/github.sh.
 sinceBuild=251
 untilBuild=261.*

resources/META-INF/plugin.xml

@@ -335,8 +335,6 @@
     <!-- See https://github.com/flutter/flutter-intellij/issues/8029 -->
     <projectService serviceImplementation="io.flutter.view.InspectorView" overrides="false"/>
 
-    <projectOpenProcessor id="flutter" implementation="io.flutter.project.FlutterProjectOpenProcessor" order="first"/>
-
     <editorNotificationProvider implementation="io.flutter.editor.FlutterPubspecNotificationProvider"/>
     <editorNotificationProvider implementation="io.flutter.inspections.SdkConfigurationNotificationProvider"/>
     <editorNotificationProvider implementation="io.flutter.editor.NativeEditorNotificationProvider"/>