[cq] remove straggling .packages support (#8724)

Fixes: #8722 and
opportunistically removes some dead code.

**Note:** nothing urgent here; just tidying up! 🧹 

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>

Author: pq

src/io/flutter/pub/PubRoot.java

@@ -33,7 +33,6 @@
 public class PubRoot {
   public static final String DOT_DART_TOOL = ".dart_tool";
   public static final String PACKAGE_CONFIG_JSON = "package_config.json";
-  public static final String DOT_PACKAGES = ".packages";
   public static final String PUBSPEC_YAML = "pubspec.yaml";
 
   @NotNull
@@ -271,17 +270,6 @@ public boolean isFlutterPlugin() {
     return FlutterUtils.isFlutterPlugin(pubspec);
   }
 
-  /**
-   * Returns true if the directory content looks like a Flutter module.
-   */
-  public boolean isFlutterModule() {
-    return root.findChild(".android") != null;
-  }
-
-  public boolean isNonEditableFlutterModule() {
-    return isFlutterModule() && root.findChild("android") == null;
-  }
-
   @Nullable
   public VirtualFile getPackageConfigFile() {
     VirtualFile rootToExpectToolsDirectory = root;
@@ -305,16 +293,6 @@ public VirtualFile getPackageConfigFile() {
     return null;
   }
 
-  @Nullable
-  public VirtualFile getPackagesFile() {
-    // Obsolete by Flutter 2.0
-    final VirtualFile packages = root.findChild(DOT_PACKAGES);
-    if (packages != null && !packages.isDirectory()) {
-      return packages;
-    }
-    return null;
-  }
-
   public @Nullable Map<String, String> getPackagesMap() {
     final var packageConfigFile = getPackageConfigFile();
     if (packageConfigFile != null) {
@@ -341,12 +319,6 @@ public boolean hasUpToDatePackages() {
       long configLastModified = new File(configFile.getPath()).lastModified();
       return pubspecLastModified < configLastModified;
     }
-    final VirtualFile packagesFile = getPackagesFile();
-    if (packagesFile != null) {
-      long pubspecLastModified = new File(pubspec.getPath()).lastModified();
-      long packagesLastModified = new File(packagesFile.getPath()).lastModified();
-      return pubspecLastModified < packagesLastModified;
-    }
     return false;
   }
 

src/io/flutter/run/MainFile.java

@@ -124,8 +124,7 @@ private static boolean isAppDir(@NotNull VirtualFile dir, @NotNull Project proje
     assert (!WorkspaceCache.getInstance(project).isBazel());
     return dir.isDirectory() && (
       dir.findChild(PubRoot.PUBSPEC_YAML) != null ||
-      dir.findChild(PubRoot.DOT_DART_TOOL) != null ||
-      dir.findChild(PubRoot.DOT_PACKAGES) != null
+      dir.findChild(PubRoot.DOT_DART_TOOL) != null
     );
   }
 

src/io/flutter/sdk/FlutterSdkUtil.java

@@ -36,12 +36,16 @@
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
-import javax.swing.*;
+import javax.swing.DefaultComboBoxModel;
+import javax.swing.JComboBox;
 import java.io.File;
 import java.io.IOException;
 import java.net.URI;
 import java.net.URISyntaxException;
-import java.util.*;
+import java.util.HashSet;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Set;
 
 public class FlutterSdkUtil {
   /**
@@ -208,16 +212,7 @@ private static boolean isFlutterSdkHomeWithoutDartSdk(@NotNull final String path
     final File dartLibFolder = new File(path + "/bin/cache/dart-sdk/lib");
     return flutterPubspecFile.isFile() && flutterToolFile.isFile() && !dartLibFolder.isDirectory();
   }
-
-  /**
-   * Checks the workspace for any open Flutter projects.
-   *
-   * @return true if an open Flutter project is found
-   */
-  public static boolean hasFlutterModules() {
-    return Arrays.stream(ProjectManager.getInstance().getOpenProjects()).anyMatch(FlutterModuleUtils::hasFlutterModule);
-  }
-
+  
   public static boolean hasFlutterModules(@NotNull Project project) {
     return FlutterModuleUtils.hasFlutterModule(project);
   }
@@ -287,21 +282,6 @@ public static String guessFlutterSdkFromPackagesFile(@NotNull Module module) {
       }
     }
 
-    // Next, try the obsolete .packages
-    for (PubRoot pubRoot : PubRoots.forModule(module)) {
-      final VirtualFile packagesFile = pubRoot.getPackagesFile();
-      if (packagesFile == null) {
-        continue;
-      }
-      // parse it
-      try {
-        final String contents = new String(packagesFile.contentsToByteArray(true /* cache contents */));
-        return parseFlutterSdkPath(contents);
-      }
-      catch (IOException ignored) {
-      }
-    }
-
     return null;
   }