Skip to content

Commit f7e0f7f

Browse files
authored
[analytics] instrument OpenSimulator, Reload, Restart (#8737)
Instruments stragglers: * `OpenSimulatorAction` * `ReloadAllFlutterApps` * `RestartAllFlutterApps` Towards: #8598 --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent 91f0460 commit f7e0f7f

3 files changed

Lines changed: 14 additions & 0 deletions

File tree

src/io/flutter/actions/OpenSimulatorAction.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
import com.intellij.openapi.actionSystem.AnAction;
1010
import com.intellij.openapi.actionSystem.AnActionEvent;
1111
import com.intellij.openapi.project.Project;
12+
import com.jetbrains.lang.dart.analytics.Analytics;
13+
import com.jetbrains.lang.dart.analytics.AnalyticsData;
1214
import icons.FlutterIcons;
1315
import io.flutter.sdk.XcodeUtils;
1416
import org.jetbrains.annotations.NotNull;
@@ -17,6 +19,8 @@
1719
public class OpenSimulatorAction extends AnAction {
1820
final boolean enabled;
1921

22+
public static final String ID = "open.simulator";
23+
2024
public OpenSimulatorAction(boolean enabled) {
2125
super("Open iOS Simulator", null, FlutterIcons.IOS);
2226
this.enabled = enabled;
@@ -47,5 +51,7 @@ public void actionPerformed(@NotNull AnActionEvent event) {
4751
//}
4852

4953
XcodeUtils.openSimulator(project);
54+
55+
Analytics.report(AnalyticsData.forAction(ID, event.getPlace(), event.getProject()));
5056
}
5157
}

src/io/flutter/actions/ReloadAllFlutterApps.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
import com.intellij.openapi.actionSystem.AnActionEvent;
1010
import com.intellij.openapi.project.Project;
1111
import com.intellij.openapi.util.Computable;
12+
import com.jetbrains.lang.dart.analytics.Analytics;
13+
import com.jetbrains.lang.dart.analytics.AnalyticsData;
1214
import icons.FlutterIcons;
1315
import io.flutter.FlutterBundle;
1416
import io.flutter.FlutterConstants;
@@ -43,5 +45,7 @@ public void actionPerformed(@NotNull AnActionEvent e) {
4345
if (reloadManager != null) {
4446
reloadManager.saveAllAndReloadAll(FlutterApp.allFromProjectProcess(project), FlutterConstants.RELOAD_REASON_MANUAL);
4547
}
48+
49+
Analytics.report(AnalyticsData.forAction(ID, e.getPlace(), e.getProject()));
4650
}
4751
}

src/io/flutter/actions/RestartAllFlutterApps.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
import com.intellij.openapi.actionSystem.AnActionEvent;
1010
import com.intellij.openapi.project.Project;
1111
import com.intellij.openapi.util.Computable;
12+
import com.jetbrains.lang.dart.analytics.Analytics;
13+
import com.jetbrains.lang.dart.analytics.AnalyticsData;
1214
import icons.FlutterIcons;
1315
import io.flutter.FlutterBundle;
1416
import io.flutter.FlutterConstants;
@@ -48,5 +50,7 @@ public void actionPerformed(@NotNull AnActionEvent e) {
4850
reloadManager
4951
.saveAllAndRestartAll(FlutterApp.allFromProjectProcess(project), FlutterConstants.RELOAD_REASON_MANUAL);
5052
}
53+
54+
Analytics.report(AnalyticsData.forAction(ID, e.getPlace(), e.getProject()));
5155
}
5256
}

0 commit comments

Comments
 (0)