Skip to content

Upgrade version of Android Studio#8946

Merged
auto-submit[bot] merged 9 commits into
flutter:mainfrom
helin24:upgrade
May 5, 2026
Merged

Upgrade version of Android Studio#8946
auto-submit[bot] merged 9 commits into
flutter:mainfrom
helin24:upgrade

Conversation

@helin24
Copy link
Copy Markdown
Member

@helin24 helin24 commented May 4, 2026

The motivations for this change:

  • The latest Dart plugin (v505) has been released, so we should start depending on it.
  • Android Studio Panda (2025.3) is now the stable release, so we should build against it.

Some other changes followed from those updates:

More on the verification issue:

  • When I generate baselines for 2025.3, it produces a line that keeps parameter names, e.g. * Deprecated constructor com.jetbrains.lang.dart.ide.template.DartTemplateContextType.<init>(java.lang.String id, java.lang.String presentableName, java.lang.Class baseContextType) is invoked in io.flutter.template.DartToplevelTemplateContextType.<init>()
  • On CI, verify does not preserve parameter names, so it finds * Deprecated constructor com.jetbrains.lang.dart.ide.template.DartTemplateContextType.<init>(java.lang.String arg0, java.lang.String arg1, java.lang.Class arg2) is invoked in io.flutter.template.DartToplevelTemplateContextType.<init>()
  • I could potentially ask CI to always generate verification reports with parameters, but this actually requires a change to Dart plugin, not Flutter plugin. So while I could do that, it would require releasing Dart again and updating the version dependency here again, which seems like a lot...
  • Instead I'm asking github.sh to instead match the class name and ignore the params. Hopefully that works.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IntelliJ platform version to 2025.3.4.6, the Dart plugin to 505.0.0, and the IntelliJ platform plugin to 2.16.0. It also transitions from the intelliLang plugin dependency to the intellij.platform.langInjection bundled module. A logical issue was identified where the CI verification script (tool/github.sh) needs to be updated to include the new build version (253) introduced by the version bump to ensure the plugin is correctly verified in CI.

Comment thread gradle.properties Outdated
@helin24 helin24 requested a review from pq May 4, 2026 20:49
Comment thread gradle/libs.versions.toml
Comment thread tool/github.sh
Comment thread gradle.properties Outdated
Comment thread gradle/libs.versions.toml
Comment thread settings.gradle.kts
Copy link
Copy Markdown
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll stop resisting 🙃

Thanks for all the follow-up!

Comment thread build.gradle.kts
@helin24
Copy link
Copy Markdown
Member Author

helin24 commented May 5, 2026

Haha we can also discuss later, along with why our build takes an hour 😢

It's not a very pleasant set of changes.

@pq
Copy link
Copy Markdown
Collaborator

pq commented May 5, 2026

Oof. An hour? Let's talk.

@helin24 helin24 added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label May 5, 2026
@auto-submit auto-submit Bot merged commit 4a1c160 into flutter:main May 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants