Upgrade version of Android Studio#8946
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the IntelliJ platform version to 2025.3.4.6, the Dart plugin to 505.0.0, and the IntelliJ platform plugin to 2.16.0. It also transitions from the intelliLang plugin dependency to the intellij.platform.langInjection bundled module. A logical issue was identified where the CI verification script (tool/github.sh) needs to be updated to include the new build version (253) introduced by the version bump to ensure the plugin is correctly verified in CI.
pq
reviewed
May 4, 2026
pq
reviewed
May 5, 2026
pq
approved these changes
May 5, 2026
Collaborator
pq
left a comment
There was a problem hiding this comment.
Ok. I'll stop resisting 🙃
Thanks for all the follow-up!
Member
Author
|
Haha we can also discuss later, along with why our build takes an hour 😢 It's not a very pleasant set of changes. |
Collaborator
|
Oof. An hour? Let's talk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivations for this change:
Some other changes followed from those updates:
lsp4ijas a dependency since Dart depends on it now.bytebuddywas also added as a new dependency (for mockito, I think?)intellij.platform.langInjection"is now a module replacingorg.intellij.intelliLang(old plugin). See notes on 253:org.intellij.intelliLangis reported as bundled module, but it's unavailable JetBrains/intellij-platform-gradle-plugin#2026update_baselines.sh- more info below.More on the verification issue:
* Deprecated constructor com.jetbrains.lang.dart.ide.template.DartTemplateContextType.<init>(java.lang.String id, java.lang.String presentableName, java.lang.Class baseContextType) is invoked in io.flutter.template.DartToplevelTemplateContextType.<init>()* Deprecated constructor com.jetbrains.lang.dart.ide.template.DartTemplateContextType.<init>(java.lang.String arg0, java.lang.String arg1, java.lang.Class arg2) is invoked in io.flutter.template.DartToplevelTemplateContextType.<init>()github.shto instead match the class name and ignore the params. Hopefully that works.