Skip to content

Commit 08080ab

Browse files
authored
[google_maps_flutter] removed old overrides (#4679)
Removed 2 overrides with the comment ``` // TODO(mklim): Remove this empty override once #40126 is fixed in stable. ``` As the issue was fixed in 2019 Related to #131791
1 parent ea49db5 commit 08080ab

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
## NEXT
2-
1+
## 2.4.16
2+
* Removes old empty override methods.
33
* Fixes unawaited_futures violations.
44

55
## 2.4.15

packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -604,20 +604,6 @@ private void setGoogleMapListener(@Nullable GoogleMapListener listener) {
604604
googleMap.setOnMapLongClickListener(listener);
605605
}
606606

607-
// @Override
608-
// The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum
609-
// does. This will override it when available even with the annotation commented out.
610-
public void onInputConnectionLocked() {
611-
// TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable.
612-
}
613-
614-
// @Override
615-
// The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum
616-
// does. This will override it when available even with the annotation commented out.
617-
public void onInputConnectionUnlocked() {
618-
// TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable.
619-
}
620-
621607
// DefaultLifecycleObserver
622608

623609
@Override

packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: google_maps_flutter_android
22
description: Android implementation of the google_maps_flutter plugin.
33
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
5-
version: 2.4.15
5+
version: 2.4.16
66

77
environment:
88
sdk: ">=2.18.0 <4.0.0"

0 commit comments

Comments
 (0)