Skip to content

[flutter_tools] remove all references to .packages in tool tests #106210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christopherfujino opened this issue Jun 17, 2022 · 0 comments
Open

[flutter_tools] remove all references to .packages in tool tests #106210

christopherfujino opened this issue Jun 17, 2022 · 0 comments
Labels
c: tech-debt Technical debt, code quality, testing, etc. P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@christopherfujino
Copy link
Contributor

Context dart-lang/sdk#48272

Pub is no longer creating .packages file, however the tool still has some tests that are creating a mock one (e.g. https://github.com/flutter/flutter/blob/496049263e4efd68ced664ee2c90db9c93f08571/packages/flutter_tools/test/general.shard/plugins_test.dart). These tests should be updated to instead create a .dart_tool/package_config.json file which is what pub is now generating.
@christopherfujino christopherfujino added tool Affects the "flutter" command-line tool. See also t: labels. P2 Important issues not at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. labels Jun 17, 2022
@flutter-triage-bot flutter-triage-bot bot added team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christopherfujino