You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The native PictureRecorder class creates an SkCanvas->Builder recorder by default as a vestigial reference to the early days of DisplayList integration where some of the native versions of ui.Canvas calls were expressed as calls on an SkCanvas and the ui.Paragraph code also called only SkCanvas methods.
The flutter::Canvas calls were all converted to using the DisplayListBuilder instead of the SkCanvas adapter months ago (except for 2 references which can be fixed). The ui.Paragraph code was also recently updated to express itself through DisplayListBuilder calls. At this point, there is no longer any reason for the flutter::PictureRecorder class to create a DisplayListCanvasRecorder just to extract the DisplayListBuilder out of it and only use that object. It should just create a DisplayListBuilder directly and be clean of any Skia objects.
The text was updated successfully, but these errors were encountered:
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
The native PictureRecorder class creates an SkCanvas->Builder recorder by default as a vestigial reference to the early days of DisplayList integration where some of the native versions of ui.Canvas calls were expressed as calls on an SkCanvas and the ui.Paragraph code also called only SkCanvas methods.
The flutter::Canvas calls were all converted to using the DisplayListBuilder instead of the SkCanvas adapter months ago (except for 2 references which can be fixed). The ui.Paragraph code was also recently updated to express itself through DisplayListBuilder calls. At this point, there is no longer any reason for the flutter::PictureRecorder class to create a DisplayListCanvasRecorder just to extract the DisplayListBuilder out of it and only use that object. It should just create a DisplayListBuilder directly and be clean of any Skia objects.
The text was updated successfully, but these errors were encountered: