Skip to content

Eliminate DisplayListCanvasRecorder from flutter::PictureRecorder #116670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flar opened this issue Dec 7, 2022 · 1 comment · Fixed by flutter/engine#38127
Closed

Eliminate DisplayListCanvasRecorder from flutter::PictureRecorder #116670

flar opened this issue Dec 7, 2022 · 1 comment · Fixed by flutter/engine#38127
Labels
engine flutter/engine repository. See also e: labels.

Comments

@flar
Copy link
Contributor

flar commented Dec 7, 2022

The native PictureRecorder class creates an SkCanvas->Builder recorder by default as a vestigial reference to the early days of DisplayList integration where some of the native versions of ui.Canvas calls were expressed as calls on an SkCanvas and the ui.Paragraph code also called only SkCanvas methods.

The flutter::Canvas calls were all converted to using the DisplayListBuilder instead of the SkCanvas adapter months ago (except for 2 references which can be fixed). The ui.Paragraph code was also recently updated to express itself through DisplayListBuilder calls. At this point, there is no longer any reason for the flutter::PictureRecorder class to create a DisplayListCanvasRecorder just to extract the DisplayListBuilder out of it and only use that object. It should just create a DisplayListBuilder directly and be clean of any Skia objects.

@flar flar added the engine flutter/engine repository. See also e: labels. label Dec 7, 2022
@flar flar added this to Display List Dec 7, 2022
@flar flar moved this to 🤔 Needs Triage in Display List Dec 7, 2022
@flar flar moved this from 🤔 Needs Triage to 🛠️ Internals in Display List Dec 7, 2022
Repository owner moved this from 🛠️ Internals to ✅ Done in Display List Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant