Skip to content

[web] lookup of gl parameters slows down surface creation #117934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonahwilliams opened this issue Jan 3, 2023 · 3 comments · Fixed by flutter/engine#38829
Closed

[web] lookup of gl parameters slows down surface creation #117934

jonahwilliams opened this issue Jan 3, 2023 · 3 comments · Fixed by flutter/engine#38829
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) dependency: skia Skia team may need to help us e: web_canvaskit CanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Web engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically

Comments

@jonahwilliams
Copy link
Member

For a given Gl/Gr context these parameters should be the same, yet we're spending ~10ms a frame when resizing the window looking these up. Either have Skia cache them or cache them ourselves.

Code is: https://github.com/google/skia/blob/b7d7e7c71b6b4935f32846587a50bc4069f562a6/modules/canvaskit/canvaskit_bindings.cpp#L204-L207

image (9)
@jonahwilliams jonahwilliams added c: performance Relates to speed or footprint issues (see "perf:" labels) e: web_canvaskit CanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Web P2 Important issues not at the top of the work list labels Jan 3, 2023
@jonahwilliams jonahwilliams mentioned this issue Jan 3, 2023
Merged
@yjbanov yjbanov added platform-web Web applications specifically engine flutter/engine repository. See also e: labels. dependency: skia Skia team may need to help us labels Jan 3, 2023
@jonahwilliams
Copy link
Member Author

Pending fix: https://skia-review.googlesource.com/c/skia/+/628842

@jonahwilliams jonahwilliams mentioned this issue Jan 13, 2023
Merged
@jonahwilliams
Copy link
Member Author

@khyati82 this is not related to platform views

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) dependency: skia Skia team may need to help us e: web_canvaskit CanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Web engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[web] cache sample and stencil params jonahwilliams/engine
2 participants
@yjbanov @jonahwilliams