Skip to content

Run plugin tests against the debug engine #143093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaaclarke opened this issue Feb 7, 2024 · 1 comment
Open

Run plugin tests against the debug engine #143093

gaaclarke opened this issue Feb 7, 2024 · 1 comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. P2 Important issues not at the top of the work list team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@gaaclarke
Copy link
Member

gaaclarke commented Feb 7, 2024

Right now plugin tests run against the release version of the flutter engine. The release version of the engine has less verification for correctness. For example, in flutter/packages#6069 it was found that a platform channel in the google_maps_flutter plugin was being used from a background thread which is a violation that can introduce race conditions. It is silently ignored in release engines, but if plugin tests were run against the debug engine we'd catch those failures and potentially others.

It is my understanding that we save debug builds but they may not be readily served by the flutter tool.

This will solve the issue for our plugins, ideally this feature would be available to external plugin developers.

@gaaclarke gaaclarke added the team-ecosystem Owned by Ecosystem team label Feb 7, 2024
@stuartmorgan-g stuartmorgan-g added c: contributor-productivity Team-specific productivity, code health, technical debt. P2 Important issues not at the top of the work list triaged-ecosystem Triaged by Ecosystem team labels Feb 13, 2024
@stuartmorgan-g
Copy link
Contributor

This would require a lot of custom tooling, but would be useful. Ideally the tooling would be in flutter so we wouldn't need to maintain a bunch of things in packages specifically (and so 3P developers could use it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. P2 Important issues not at the top of the work list team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Development

No branches or pull requests

2 participants