Skip to content

Animation during orientation change is wrong #168118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkwingsmt opened this issue Apr 30, 2025 · 2 comments
Open

Animation during orientation change is wrong #168118

dkwingsmt opened this issue Apr 30, 2025 · 2 comments
Labels
a: animation Animation APIs f: cupertino flutter/packages/flutter/cupertino repository found in release: 3.29 Found to occur in 3.29 found in release: 3.32 Found to occur in 3.32 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Apr 30, 2025

Expected:

trim.9CAFF5B0-BB87-4FEA-BD8F-104D74C46746.MOV

Actual:

trim.336CE501-AEA4-48AD-AD79-40BBA0C869B0.MOV

Reproduction:

import 'package:flutter/cupertino.dart';

void main() => runApp(const App());

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      home: Center(
        child: Builder(builder: (BuildContext context) {
            return CupertinoButton(
              onPressed: () {
                showCupertinoDialog<void>(
                  context: context,
                  builder: (BuildContext context) => CupertinoAlertDialog(
                    title: const Text('The title'),
                    actions: <Widget>[
                      CupertinoDialogAction(
                        child: const Text('One'),
                        onPressed: () {
                          Navigator.pop(context);
                        },
                      ),
                      CupertinoDialogAction(
                        child: const Text('Two'),
                        onPressed: () {
                          Navigator.pop(context);
                        },
                      ),
                    ],
                  ),
                );
              },
              child: const Text('Flutter'),
            );
          }),
      ),
    );
  }
}

Running e9b4a6a on a iPhone 16 Pro.

@darshankawar darshankawar added the in triage Presently being triaged by the triage team label May 2, 2025
@darshankawar
Copy link
Member

Thanks for the report. I was able to replicate the reported behavior on latest sdk versions using iPhone 15 as well.

stable : 3.29.3
master : 3.32.0-1.0.pre.375

@darshankawar darshankawar added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository has reproducible steps The issue has been confirmed reproducible and is ready to work on found in release: 3.29 Found to occur in 3.29 found in release: 3.32 Found to occur in 3.32 team-design Owned by Design Languages team a: animation Animation APIs and removed in triage Presently being triaged by the triage team labels May 2, 2025
@dkwingsmt
Copy link
Contributor Author

dkwingsmt commented May 2, 2025

I found that this was heavily discussed in #16322. This issue was closed by flutter/engine#40730, which improved this problem from "super bad" to "ok-ish bad" as the current state.

An ideal state in my opinion should use no distortion at all, because any distortion is extremely noticeable. Some extent of cropping is probably needed. My rough proposal is to add a new method to the framework and allow each widget customize their in-rotation transition.

Possible resource:

@dkwingsmt dkwingsmt added P2 Important issues not at the top of the work list triaged-design Triaged by Design Languages team labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: animation Animation APIs f: cupertino flutter/packages/flutter/cupertino repository found in release: 3.29 Found to occur in 3.29 found in release: 3.32 Found to occur in 3.32 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Development

No branches or pull requests

2 participants