Skip to content

_WidgetDebugSize #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Oct 18, 2016 · 3 comments
Closed

_WidgetDebugSize #6377

Hixie opened this issue Oct 18, 2016 · 3 comments
Labels
c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Comments

@Hixie
Copy link
Contributor

Hixie commented Oct 18, 2016

To try to catch SizeObserver patterns, we should have the BuildContext.size getter return an object that throws if it is used during building.

@Hixie
Copy link
Contributor Author

Hixie commented Oct 18, 2016

(so e.g. you can't read the size during layout, then wait one frame and use the size during build)

@Hixie Hixie added affects: dev experience c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. labels Oct 18, 2016
@Hixie Hixie added this to the 4: Make Hixie proud milestone Oct 18, 2016
@Hixie Hixie modified the milestones: 2: Make Early Adopters happy, 4: Make Hixie proud Jan 6, 2017
@Hixie Hixie added the c: API break Backwards-incompatible API changes label Jan 6, 2017
@Hixie
Copy link
Contributor Author

Hixie commented Apr 7, 2017

There's no way to do this. Even if we made a fake Size class that proxied everything to the real one, you still couldn't actually tell if you were being used at the wrong time because you could be being taken from one pipeline to another.

@Hixie Hixie closed this as completed Apr 7, 2017
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

No branches or pull requests

1 participant