Skip to content

engine post commit tests are running off of old code #63802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaaclarke opened this issue Aug 14, 2020 · 2 comments
Closed

engine post commit tests are running off of old code #63802

gaaclarke opened this issue Aug 14, 2020 · 2 comments
Labels
team-infra Owned by Infrastructure team

Comments

@gaaclarke
Copy link
Member

This build was red because of unit tests failures: https://ci.chromium.org/p/flutter/builders/prod/Mac%20iOS%20Engine/6379

This build should have been compiling with the fix: https://ci.chromium.org/p/flutter/builders/prod/Mac%20iOS%20Engine/6380

Despite listing the right SHA in the build, the build didn't actually include the fix and seems to have been running against the previous code since the next build was green.

cc @godofredoc

@gaaclarke
Copy link
Member Author

These tests weren't actually fixed completely, they went from broken to flakey which made them look like there was an infra problem. There is no infra problem.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-infra Owned by Infrastructure team
Projects
None yet
Development

No branches or pull requests

1 participant