[plugins] [ci] Plugins with custom analysis_options.yaml are failing analyze test in flutter/flutter.

[ditman]

The flutter/plugins roller is failing pre-submit:

Activated flutter_plugin_tools 0.0.45+3.
▌09:47:03▐ ELAPSED TIME: 5.143s for ../../../k/flutter/bin/cache/dart-sdk/bin/pub global activate flutter_plugin_tools in ../../tmp/t/pluginsDYZTNQ
▌09:47:03▐ RUNNING: cd ../../tmp/t/pluginsDYZTNQ; ../../../k/flutter/bin/cache/dart-sdk/bin/pub global run flutter_plugin_tools analyze
Verifying analysis settings...
Found an extra analysis_options.yaml in /b/s/w/ir/tmp/t/pluginsDYZTNQ/packages/android_alarm_manager/analysis_options.yaml.
If this was deliberate, pass the package to the analyze command with the --custom-analysis flag and try again.

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20flutter_plugins/5356/overview

It seems that the issue was introduced by this change:

flutter/plugins#3703

We need to configure the analysis command to accept custom analysis_options.yaml files, either here:

• flutter/dev/bots/test.dart

  Lines 851 to 860 in 2e06ed0

  	await runCommand(
  	pub,
  	<String>[
  	'global',
  	'run',
  	'flutter_plugin_tools',
  	'analyze',
  	],
  	workingDirectory: checkout.path,
  	);

• Or publish a new version of flutter_plugin_tools which allows for custom yaml files.

[stuartmorgan-g]

Whitelisting all the current packages using the existing flag seems like a good option, since the goal is not to add new ones over time.

[ditman]

There's a bug with the current version of the tool here:

https://github.com/flutter/plugins/blob/master/script/tool/lib/src/analyze_command.dart#L45-L50

When argResults[_customAnalysisFlag] is empty [], it actually is: [""] and the any check runs once (against an empty string), so p.join(packagesDir.path, directory) is packages.

That is effectively allowing all packages to go through. I'm going to add a null check to directory so this case is contemplated, but it's probably a bad default value (maybe coming from the .sh) :/

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.