Commit 03623b6
authored
[camerax] Ignore new
The Dart analyzer will soon be changed so that if the `default` clause
of a `switch` statement is determined to be unreachable by the
exhaustiveness checker, a new warning of type
`unreachable_switch_default` will be issued. This parallels the behavior
of the existing `unreachable_switch_case` warning, which is issued
whenever a `case` clause of a `switch` statement is determined to be
unreachable.
In the vast majority of cases, the most reasonable way to address the
warning is to remove the unreachable `default` clause. However, in a few
rare cases, it makes sense to keep the `default` clause, because it's
intentionally future-proofing the code in case new possible values are
added to the enum being switched on.
Three of these rare cases crop up in the camerax package. This change
adds `ignore` comments to avoid a spurious warning.unreachable_switch_default warning. (#7592)1 parent d07c025 commit 03623b6
3 files changed
Lines changed: 3 additions & 3 deletions
File tree
- packages/camera/camera_android_camerax
- lib/src
- test
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | | - | |
| 188 | + | |
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| |||
0 commit comments