Skip to content

Commit 1d59196

Browse files
authored
Appended period remove & Uri parsing fix. (#131293)
Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously. As for example: ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log. ``` Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode). ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log ``` Fixes: #131166
1 parent efc9e16 commit 1d59196

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/flutter_tools/lib/src/reporting/crash_reporting.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class CrashReporter {
6969

7070
/// Prints instructions for filing a bug about the crash.
7171
Future<void> informUser(CrashDetails details, File crashFile) async {
72-
_logger.printError('A crash report has been written to ${crashFile.path}.');
72+
_logger.printError('A crash report has been written to ${crashFile.path}');
7373
_logger.printStatus('This crash may already be reported. Check GitHub for similar crashes.', emphasis: true);
7474

7575
final String similarIssuesURL = GitHubTemplateCreator.toolCrashSimilarIssuesURL(details.error.toString());

packages/flutter_tools/test/general.shard/crash_reporting_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ void main() {
100100
expect(logger.statusText, contains('NoPIIFakeDoctorText'));
101101
expect(logger.statusText, isNot(contains('Ignored')));
102102
expect(logger.statusText, contains('https://github.com/flutter/flutter/issues/new'));
103-
expect(logger.errorText, contains('A crash report has been written to ${file.path}.'));
103+
expect(logger.errorText.trim(), 'A crash report has been written to ${file.path}');
104104
});
105105

106106
testWithoutContext('suppress analytics', () async {

0 commit comments

Comments
 (0)