Skip to content

Commit 584fc70

Browse files
committed
[tool] Build all_packages command against Flutter Android SDK version to match example apps
1 parent cb4fb13 commit 584fc70

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

script/tool/lib/src/create_all_packages_app_command.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,9 @@ dependencies {}
243243
gradleFile,
244244
replacements: <String, List<String>>{
245245
if (gradleFileIsKotlin)
246-
'compileSdk': <String>['compileSdk = 34']
246+
'compileSdk': <String>['compileSdk = flutter.compileSdkVersion']
247247
else ...<String, List<String>>{
248-
'compileSdkVersion': <String>['compileSdk 34'],
248+
'compileSdkVersion': <String>['compileSdk flutter.compileSdkVersion'],
249249
}
250250
},
251251
regexReplacements: <RegExp, List<String>>{

script/tool/test/create_all_packages_app_command_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ android {
342342
buildGradle,
343343
containsAll(<Matcher>[
344344
contains('This is the legacy file'),
345-
contains('compileSdk 34'),
345+
contains('compileSdk flutter.compileSdkVersion'),
346346
]));
347347
});
348348

@@ -375,7 +375,7 @@ android {
375375
expect(
376376
buildGradle,
377377
containsAll(<Matcher>[
378-
contains('compileSdk 34'),
378+
contains('compileSdk flutter.compileSdkVersion'),
379379
contains('androidx.lifecycle:lifecycle-runtime'),
380380
]));
381381
});

0 commit comments

Comments
 (0)