Skip to content

Commit 820e3e5

Browse files
authored
[image_picker_android] Removes unneeded permissions from tests (#3433)
[image_picker_android] Removes unneeded permissions from tests
1 parent 5d4086e commit 820e3e5

File tree

1 file changed

+10
-28
lines changed

1 file changed

+10
-28
lines changed

packages/image_picker/image_picker_android/android/src/test/java/io/flutter/plugins/imagepicker/ImagePickerDelegateTest.java

Lines changed: 10 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre
148148

149149
@Test
150150
@Config(sdk = 30)
151-
public void
152-
chooseImageFromGallery_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
153-
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
154-
.thenReturn(true);
151+
public void chooseImageFromGallery_launchesChooseFromGalleryIntent() {
155152

156153
ImagePickerDelegate delegate = createDelegate();
157154
delegate.chooseImageFromGallery(new ImageOutputOptions(null, null, null), false, mockResult);
@@ -163,10 +160,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre
163160

164161
@Test
165162
@Config(minSdk = 33)
166-
public void
167-
chooseImageFromGallery_WithPhotoPicker_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
168-
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
169-
.thenReturn(true);
163+
public void chooseImageFromGallery_withPhotoPicker_launchesChooseFromGalleryIntent() {
170164

171165
ImagePickerDelegate delegate = createDelegate();
172166
delegate.chooseImageFromGallery(new ImageOutputOptions(null, null, null), true, mockResult);
@@ -178,10 +172,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre
178172

179173
@Test
180174
@Config(sdk = 30)
181-
public void
182-
chooseMultiImageFromGallery_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
183-
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
184-
.thenReturn(true);
175+
public void chooseMultiImageFromGallery_launchesChooseFromGalleryIntent() {
185176

186177
ImagePickerDelegate delegate = createDelegate();
187178
delegate.chooseMultiImageFromGallery(
@@ -195,10 +186,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre
195186

196187
@Test
197188
@Config(minSdk = 33)
198-
public void
199-
chooseMultiImageFromGallery_WithPhotoPicker_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
200-
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
201-
.thenReturn(true);
189+
public void chooseMultiImageFromGallery_withPhotoPicker_launchesChooseFromGalleryIntent() {
202190

203191
ImagePickerDelegate delegate = createDelegate();
204192
delegate.chooseMultiImageFromGallery(
@@ -212,10 +200,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre
212200

213201
@Test
214202
@Config(sdk = 30)
215-
public void
216-
chooseVideoFromGallery_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
217-
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
218-
.thenReturn(true);
203+
public void chooseVideoFromGallery_launchesChooseFromGalleryIntent() {
219204

220205
ImagePickerDelegate delegate = createDelegate();
221206
delegate.chooseVideoFromGallery(new VideoOptions(null), true, mockResult);
@@ -227,10 +212,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre
227212

228213
@Test
229214
@Config(minSdk = 33)
230-
public void
231-
chooseVideoFromGallery_WithPhotoPicker_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
232-
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
233-
.thenReturn(true);
215+
public void chooseVideoFromGallery_withPhotoPicker_launchesChooseFromGalleryIntent() {
234216

235217
ImagePickerDelegate delegate = createDelegate();
236218
delegate.chooseVideoFromGallery(new VideoOptions(null), true, mockResult);
@@ -252,7 +234,7 @@ public void takeImageWithCamera_whenPendingResultExists_finishesWithAlreadyActiv
252234
}
253235

254236
@Test
255-
public void takeImageWithCamera_whenHasNoCameraPermission_RequestsForPermission() {
237+
public void takeImageWithCamera_whenHasNoCameraPermission_requestsForPermission() {
256238
when(mockPermissionManager.isPermissionGranted(Manifest.permission.CAMERA)).thenReturn(false);
257239
when(mockPermissionManager.needRequestCameraPermission()).thenReturn(true);
258240

@@ -265,7 +247,7 @@ public void takeImageWithCamera_whenHasNoCameraPermission_RequestsForPermission(
265247
}
266248

267249
@Test
268-
public void takeImageWithCamera_whenCameraPermissionNotPresent_RequestsForPermission() {
250+
public void takeImageWithCamera_whenCameraPermissionNotPresent_requestsForPermission() {
269251
when(mockPermissionManager.needRequestCameraPermission()).thenReturn(false);
270252

271253
ImagePickerDelegate delegate = createDelegate();
@@ -396,7 +378,7 @@ public void onActivityResult_whenPickFromGalleryCanceled_storesNothingInCache()
396378
}
397379

398380
@Test
399-
public void onActivityResult_whenImagePickedFromGallery_andNoResizeNeeded_StoresImageInCache() {
381+
public void onActivityResult_whenImagePickedFromGallery_andNoResizeNeeded_storesImageInCache() {
400382
ImagePickerDelegate delegate = createDelegate();
401383

402384
delegate.onActivityResult(
@@ -501,7 +483,7 @@ public void onActivityResult_whenImageTakenWithCamera_andNoResizeNeeded_finishes
501483

502484
@Test
503485
public void
504-
retrieveLostImage_ShouldBeAbleToReturnLastItemFromResultMapWhenSingleFileIsRecovered() {
486+
retrieveLostImage_shouldBeAbleToReturnLastItemFromResultMapWhenSingleFileIsRecovered() {
505487
Map<String, Object> resultMap = new HashMap<>();
506488
ArrayList<String> pathList = new ArrayList<>();
507489
pathList.add("/example/first_item");

0 commit comments

Comments
 (0)