Skip to content

Commit b745dcc

Browse files
committed
Remove resolved todo and fix dartdocs
1 parent 8fc1fa0 commit b745dcc

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

packages/video_player/video_player_android/example/lib/mini_controller.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ class MiniController extends ValueNotifier<VideoPlayerValue> {
219219
Completer<void>? _creatingCompleter;
220220
StreamSubscription<dynamic>? _eventSubscription;
221221

222-
/// The id of a texture that hasn't been initialized.
222+
/// The id of a player that hasn't been initialized.
223223
@visibleForTesting
224224
static const int kUninitializedPlayerId = -1;
225225
int _playerId = kUninitializedPlayerId;
@@ -424,7 +424,7 @@ class _VideoPlayerState extends State<VideoPlayer> {
424424
void initState() {
425425
super.initState();
426426
_playerId = widget.controller.playerId;
427-
// Need to listen for initialization events since the actual texture ID
427+
// Need to listen for initialization events since the actual player ID
428428
// becomes available after asynchronous initialization finishes.
429429
widget.controller.addListener(_listener);
430430
}

packages/video_player/video_player_android/lib/src/android_video_player.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ import 'package:video_player_platform_interface/video_player_platform_interface.
1313

1414
import 'messages.g.dart';
1515

16-
// TODO(FirentisTFW): Remove the ignore and rename parameters when adding support for platform views.
17-
// ignore_for_file: avoid_renaming_method_parameters
18-
1916
/// An Android implementation of [VideoPlayerPlatform] that uses the
2017
/// Pigeon-generated [VideoPlayerApi].
2118
class AndroidVideoPlayer extends VideoPlayerPlatform {

0 commit comments

Comments
 (0)