Skip to content

Commit d59eeae

Browse files
committed
Remove web-renderer from dart test command.
1 parent c1d794d commit d59eeae

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

script/tool/lib/src/dart_test_command.dart

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,9 @@ class DartTestCommand extends PackageLoopingCommand {
108108
platform = 'chrome';
109109
}
110110

111-
// All the web tests assume the canvaskit renderer currently.
112-
final String? webRenderer = (platform == 'chrome') ? 'canvaskit' : null;
113111
bool passed;
114112
if (package.requiresFlutter()) {
115-
passed = await _runFlutterTests(package,
116-
platform: platform, webRenderer: webRenderer);
113+
passed = await _runFlutterTests(package, platform: platform);
117114
} else {
118115
passed = await _runDartTests(package, platform: platform);
119116
}
@@ -122,7 +119,7 @@ class DartTestCommand extends PackageLoopingCommand {
122119

123120
/// Runs the Dart tests for a Flutter package, returning true on success.
124121
Future<bool> _runFlutterTests(RepositoryPackage package,
125-
{String? platform, String? webRenderer}) async {
122+
{String? platform}) async {
126123
final String experiment = getStringArg(kEnableExperiment);
127124

128125
final int exitCode = await processRunner.runAndStream(
@@ -134,7 +131,6 @@ class DartTestCommand extends PackageLoopingCommand {
134131
// Flutter defaults to VM mode (under a different name) and explicitly
135132
// setting it is deprecated, so pass nothing in that case.
136133
if (platform != null && platform != 'vm') '--platform=$platform',
137-
if (webRenderer != null) '--web-renderer=$webRenderer',
138134
],
139135
workingDir: package.directory,
140136
);

script/tool/test/dart_test_command_test.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,6 @@ test_on: vm && browser
331331
'test',
332332
'--color',
333333
'--platform=chrome',
334-
'--web-renderer=canvaskit',
335334
],
336335
package.path),
337336
]),
@@ -360,7 +359,6 @@ test_on: vm && browser
360359
'test',
361360
'--color',
362361
'--platform=chrome',
363-
'--web-renderer=canvaskit',
364362
],
365363
plugin.path),
366364
]),
@@ -390,7 +388,6 @@ test_on: vm && browser
390388
'test',
391389
'--color',
392390
'--platform=chrome',
393-
'--web-renderer=canvaskit',
394391
],
395392
plugin.path),
396393
]),
@@ -420,7 +417,6 @@ test_on: vm && browser
420417
'test',
421418
'--color',
422419
'--platform=chrome',
423-
'--web-renderer=canvaskit',
424420
],
425421
plugin.path),
426422
]),
@@ -495,7 +491,6 @@ test_on: vm && browser
495491
'test',
496492
'--color',
497493
'--platform=chrome',
498-
'--web-renderer=canvaskit',
499494
],
500495
plugin.path),
501496
]),

0 commit comments

Comments
 (0)