Skip to content

Commit d9f7041

Browse files
[video_player] Fix Android lints (#3886)
Removes lint-baseline.xml and fixes all exposed lints. Includes an update of Pigeon to the latest version, to pick up warning fixes in generated code. Part of flutter/flutter#88011
1 parent 2642249 commit d9f7041

File tree

11 files changed

+495
-1127
lines changed

11 files changed

+495
-1127
lines changed

packages/video_player/video_player_android/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.4.7
2+
3+
* Fixes Java warnings.
4+
15
## 2.4.6
26

37
* Fixes compatibility with AGP versions older than 4.2.

packages/video_player/video_player_android/android/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ android {
4141
checkAllWarnings true
4242
warningsAsErrors true
4343
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
44-
baseline file("lint-baseline.xml")
4544
}
4645
compileOptions {
4746
sourceCompatibility JavaVersion.VERSION_1_8

packages/video_player/video_player_android/android/lint-baseline.xml

Lines changed: 0 additions & 653 deletions
This file was deleted.

packages/video_player/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/CustomSSLSocketFactory.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@
1313
import javax.net.ssl.SSLSocket;
1414
import javax.net.ssl.SSLSocketFactory;
1515

16+
// SSLSocketFactory does not have nullability annotations.
17+
@SuppressWarnings("UnknownNullness")
1618
public class CustomSSLSocketFactory extends SSLSocketFactory {
17-
private SSLSocketFactory sslSocketFactory;
19+
private final SSLSocketFactory sslSocketFactory;
1820

1921
public CustomSSLSocketFactory() throws KeyManagementException, NoSuchAlgorithmException {
2022
SSLContext context = SSLContext.getInstance("TLS");

0 commit comments

Comments
 (0)